Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: renamed remote's name. #26050

Closed
wants to merge 1 commit into from
Closed

doc: renamed remote's name. #26050

wants to merge 1 commit into from

Conversation

thangktran
Copy link
Contributor

To keep consistency through-out the guide.

Fixes: #26045

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 11, 2019
@ghost
Copy link

ghost commented Feb 12, 2019

@thangktran：Please remove '.' at the end of your submit statement and forcely push it, then you can pass CI test :)

@thangktran
doc: renamed remote's name
0f480e1 
To keep consistency through-out the guide.

Fixes: nodejs#26045
@thangktran thangktran force-pushed the thangktran/fix-pull-request-guide branch from 6d26d55 to 0f480e1 Compare February 12, 2019 05:25
@thangktran
Copy link
Contributor Author

@thangktran：Please remove '.' at the end of your submit statement and forcely push it, then you can pass CI test :)

Thank you for your input. I've corrected it.

@Trott
Copy link
Member

Trott commented Feb 12, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2573/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 12, 2019
@addaleax
Copy link
Member

Landed in 1c66ad4, thanks for the PR! 🎉

@addaleax addaleax closed this Feb 13, 2019
addaleax pushed a commit that referenced this pull request Feb 13, 2019
@thangktran @addaleax
doc: renamed remote's name
1c66ad4 
To keep consistency through-out the guide.

Fixes: #26045

PR-URL: #26050
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@thangktran thangktran deleted the thangktran/fix-pull-request-guide branch February 14, 2019 12:17
targos pushed a commit that referenced this pull request Feb 14, 2019
@thangktran @targos
doc: renamed remote's name
21e6d35 
To keep consistency through-out the guide.

Fixes: #26045

PR-URL: #26050
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@antsmartian antsmartian antsmartian approved these changes

@hiroppy hiroppy hiroppy approved these changes

@shisama shisama shisama approved these changes

@ckotzbauer ckotzbauer ckotzbauer approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: misleading remote repo
8 participants
@thangktran @Trott @addaleax @antsmartian @hiroppy @shisama @ckotzbauer @nodejs-github-bot