-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: allocate Buffer memory using ArrayBuffer allocator #26207
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
07cda17
deps: V8: cherry-pick d3308d0
addaleax 1b6bbca
src: make IsolateData store ArrayBufferAllocator
addaleax 814c8a9
worker: copy transferList ArrayBuffers on unknown allocator
addaleax b2f9bb1
src: add debugging array allocator
addaleax 41e81b1
src: add allocation utils to env
addaleax 1e17828
fixup! src: add allocation utils to env
addaleax 5854771
fixup! src: add allocation utils to env
addaleax a55092f
src: allocate Buffer memory using ArrayBuffer allocator
addaleax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AllocatedLibuvBuffer
? Or instead of storing auv_buf_t
as member, store the fields that can be used to wrap/unwrapuv_buf_t
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I’m not super happy with the name either. I wouldn’t want to include a reference to libuv, because
uv_but_t
was just chosen here as a nicer variant ofstd::pair<char*,size_t>
that happens to work nicely with some pieces in our code base that already use it the same way.Ideally, the name would be something that refers to the fact that this memory is usable for
ArrayBuffer
s, but that would make any name even longer …ArrayBufferBuffer
sounds weird,ArrayBufferStorage
orArrayBufferMemory
is long but maybe okay, …?I don’t really have strong feelings about that… I can make that change after/while rebasing (later today, after #26201 lands).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was what I guessed as well, thanks for the explanation. I don't have strong feelings about using
uv_buf_t
underneath, but it would be nice to mention why it is chosen in the comments as one may think thatAllocatedBuffer
depends on libuv for a more sophisticated reason.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joyeecheung Does 1e17828 sound good to you?
(& to be clear, I’m still happy about suggestions for another name for this class if that fits better.)