Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor node options parsers to mitigate MSVC bug #26280

Merged
merged 2 commits into from
Mar 4, 2019
Merged

src: refactor node options parsers to mitigate MSVC bug #26280

merged 2 commits into from
Mar 4, 2019

Commits on Mar 4, 2019

  1. src: refactor node options parsers to mitigate MSVC bug 

    PR-URL: nodejs#26280
Fixes: nodejs#25593
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @refack
    refack committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    af8b92c View commit details
    Browse the repository at this point in the history

  2. src: fix warnings around node_options 

    * header explicit usage, order, and reduce use of `*-inl.h`
* pointer -> const reference when possible
* no variable recyclicng
* `std::begin/end` prefered over `instance.begin/end`
* `USE` for explicit unused resaults

PR-URL: nodejs#26280
Fixes: nodejs#25593
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @refack
    refack committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    2c6d94f View commit details
    Browse the repository at this point in the history