Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
src: refactor node options parsers to mitigate MSVC bug #26280
As you predicted the fix in #25596 was temporary, and the issue came back. The current code in
If the issue is still a static initialization order thing, It's not obvious to me how some of the changes here (e.g. to
Other than that, the code changes here look good to me. It's unfortunate that the code has to be bloated up a bit, but it's clear that fixing a broken build is more important.
Do we know what change caused this? Should that have gotten a red CI? (Or is it still only debug builds?)
I also can't reproduce this locally on Windows on
Reduced some bloat.
Feb 25, 2019
Rebased into two commits (1) bug fix and (2) fix warnings