Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: napi_get_value_bigint_words argument order #26300

Closed
wants to merge 1 commit into from
Closed

doc: napi_get_value_bigint_words argument order #26300

wants to merge 1 commit into from

Conversation

no2chem
Copy link
Contributor

@no2chem no2chem commented Feb 25, 2019

The documentation for napi_get_value_bigint_words appears to have the arguments for word_count and sign_bit flipped. This PR changes the order in the documentation to match the correct order.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Feb 25, 2019
addaleax
addaleax approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mhdawson
mhdawson approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for helping to improve the docs:)

@mhdawson
Copy link
Member

LIE CI run: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2719/ since its doc change only.

@mhdawson
Copy link
Member

Landed in f4257a2

@mhdawson mhdawson closed this Feb 28, 2019
mhdawson pushed a commit that referenced this pull request Feb 28, 2019
@no2chem @mhdawson
doc: napi_get_value_bigint_words argument order
f4257a2 
PR-URL: #26300
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@no2chem @addaleax
doc: napi_get_value_bigint_words argument order
7bf6309 
PR-URL: #26300
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@no2chem no2chem deleted the patch-2 branch March 3, 2019 20:41
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@no2chem @mhdawson @jasnell @addaleax @lpinca @nodejs-github-bot