Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: napi_get_value_bigint_words argument order #26300

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@no2chem
Copy link
Contributor

commented Feb 25, 2019

The documentation for napi_get_value_bigint_words appears to have the arguments for word_count and sign_bit flipped. This PR changes the order in the documentation to match the correct order.

Checklist
@addaleax
Copy link
Member

left a comment

Thanks!

@lpinca

lpinca approved these changes Feb 25, 2019

@mhdawson
Copy link
Member

left a comment

LGTM, thanks for helping to improve the docs:)

@mhdawson

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

@mhdawson

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Landed in f4257a2

@mhdawson mhdawson closed this Feb 28, 2019

mhdawson added a commit that referenced this pull request Feb 28, 2019

doc: napi_get_value_bigint_words argument order
PR-URL: #26300
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request Mar 1, 2019

doc: napi_get_value_bigint_words argument order
PR-URL: #26300
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@no2chem no2chem deleted the no2chem:patch-2 branch Mar 3, 2019

@BridgeAR BridgeAR referenced this pull request Mar 4, 2019

Merged

v11.11.0 proposal #26322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.