Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change 2018 to 2019 for 10.15.3 entry #26584

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@cprince
Copy link
Contributor

commented Mar 11, 2019

The most minor of changes, a typo in the Changelog!

This is the first time I've looked at the node changelog and, because of the typo, I thought I was in the wrong place. Hope this helps!

Checklist
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt

This comment has been minimized.

vsemozhetbyt added a commit that referenced this pull request Mar 11, 2019

doc: fix year in changelog
Most minor, 2018 should be 2019 for 10.15.3

PR-URL: #26584
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

Landed in 06879aa
Thank you!

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

This does not land cleanly on v11. It seems like no v10 changelog has landed on v11 since v10.12.0? @nodejs/releasers to me this seems like a mistake?

@targos

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

No, this is normal. We don't backport release commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.