Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove eslint rule no-let-in-for-declaration #26715

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@gengjiawen
Copy link
Member

commented Mar 17, 2019

In continue our discussion in #26562 (comment)

cc @targos @ZYSzys @Trott @BridgeAR

Maybe still add a label don't land on 6.x though the last 6.x release has been drafted.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@richardlau
Copy link
Member

left a comment

Please also remove

node-core/no-let-in-for-declaration: error

@gengjiawen gengjiawen force-pushed the gengjiawen:remove_no_let_rule branch from 51768bc to 8da5542 Mar 17, 2019

@gengjiawen

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2019

Please also remove

node/lib/.eslintrc.yaml

Line 20 in 32853c0

node-core/no-let-in-for-declaration: error

Fixed.

@richardlau

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

I'm happy for this to land before Node.js 6 goes End-of-Life at the end of April as #26684 is the last planned release and nothing is landing there without a good deal of caution.

@gengjiawen

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2019

I'm happy for this to land before Node.js 6 goes End-of-Life at the end of April as #26684 is the last planned release and nothing is landing there without a good deal of caution.

I am happy that we can use native async await in community libs as node 6 reaches EOL :)

@targos

targos approved these changes Mar 17, 2019

@ZYSzys

ZYSzys approved these changes Mar 17, 2019

@danbev

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@gengjiawen

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

@danbev Can you import this ? Thanks.

Trott added a commit to Trott/io.js that referenced this pull request Mar 26, 2019

tools: remove eslint rule no-let-in-for-declaration
PR-URL: nodejs#26715
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

Landed in 8209cae

@Trott Trott closed this Mar 26, 2019

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

tools: remove eslint rule no-let-in-for-declaration
PR-URL: nodejs#26715
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

tools: remove eslint rule no-let-in-for-declaration
PR-URL: nodejs#26715
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

tools: remove eslint rule no-let-in-for-declaration
PR-URL: nodejs#26715
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos added a commit that referenced this pull request Mar 27, 2019

tools: remove eslint rule no-let-in-for-declaration
PR-URL: #26715
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.