test: make module test pass with NODE_PENDING_DEPRECATION #27019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some people set the `NODE_PENDING_DEPRECATION` environment variable globally. This makes the test added in 115f0f5 pass when that is the case. Refs: nodejs#26823
richardlau
approved these changes
Mar 30, 2019
cjihrig
approved these changes
Mar 31, 2019
BridgeAR
approved these changes
Mar 31, 2019
BridgeAR
added
the
author ready
|
Landed in 198d7a4 🎉 |
ZYSzys
pushed a commit
that referenced
this pull request
Apr 3, 2019
Some people set the `NODE_PENDING_DEPRECATION` environment variable globally. This makes the test added in 115f0f5 pass when that is the case. Refs: #26823 PR-URL: #27019 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 4, 2019
Some people set the `NODE_PENDING_DEPRECATION` environment variable globally. This makes the test added in 115f0f5 pass when that is the case. Refs: #26823 PR-URL: #27019 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 9, 2019
Some people set the `NODE_PENDING_DEPRECATION` environment variable globally. This makes the test added in 115f0f5 pass when that is the case. Refs: #26823 PR-URL: #27019 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 10, 2019
Some people set the `NODE_PENDING_DEPRECATION` environment variable globally. This makes the test added in 115f0f5 pass when that is the case. Refs: #26823 PR-URL: #27019 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people set the
NODE_PENDING_DEPRECATIONenvironment variableglobally. This makes the test added in 115f0f5
pass when that is the case.
Refs: #26823
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes