Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-benchmark-module #27094

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@Trott
Copy link
Member

commented Apr 4, 2019

A recent commit broke test-benchmark-module. This fixes it.

Culprit is #26970.

Collaborators, please 馃憤 here if you approve fast-tracking.

@BridgeAR @nodejs/testing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: fix test-benchmark-module
A recent commit broke test-benchmark-module. This fixes it.

Culprit is #26970.

@Trott Trott added the fast-track label Apr 4, 2019

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

@danbev

danbev approved these changes Apr 5, 2019

@Trott Trott added the author ready label Apr 5, 2019

@bengl

bengl approved these changes Apr 5, 2019

Trott added a commit to Trott/io.js that referenced this pull request Apr 5, 2019

test: fix test-benchmark-module
A recent commit broke test-benchmark-module. This fixes it.

PR-URL: nodejs#27094
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

Landed in c86883c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.