Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add mustCall in test-fs-readfilesync-pipe-large.js #27458

Closed
wants to merge 1 commit into from
Closed

test: add mustCall in test-fs-readfilesync-pipe-large.js #27458

wants to merge 1 commit into from

Conversation

sinoon
Copy link
Contributor

@sinoon sinoon commented Apr 28, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 28, 2019
@starkwang starkwang added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 28, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22766/

@oyyd
Copy link
Contributor

oyyd commented Apr 28, 2019

please leave 👍 to fast track

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22784/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22805/

@oyyd oyyd added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 30, 2019
@oyyd
Copy link
Contributor

oyyd commented Apr 30, 2019

Landed in 034a568, thanks!

You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute.

@oyyd oyyd closed this Apr 30, 2019
oyyd pushed a commit that referenced this pull request Apr 30, 2019
@sinoon @oyyd
test: add mustCall in test-fs-readfilesync-pipe-large.js
034a568 
PR-URL: #27458
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Apr 30, 2019
@sinoon @targos
test: add mustCall in test-fs-readfilesync-pipe-large.js
e21f035 
PR-URL: #27458
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request May 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antsmartian antsmartian antsmartian approved these changes

@yorkie yorkie yorkie approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@starkwang starkwang starkwang approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sinoon @nodejs-github-bot @oyyd @antsmartian @yorkie @cjihrig @gireeshpunathil @starkwang @ZYSzys