Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: remove extra shallow copy #27801

Closed

Conversation

@zero1five
Copy link
Contributor

commented May 21, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@ZYSzys
ZYSzys approved these changes May 21, 2019
@nodejs-github-bot

This comment has been minimized.

@lpinca
lpinca approved these changes May 21, 2019
@nodejs-github-bot

This comment has been minimized.

@ZYSzys ZYSzys added the author ready label May 23, 2019

@danbev

This comment has been minimized.

Copy link
Member

commented May 24, 2019

Re-run of failing node-test-commit-windows-fanned (✔️)
Re-run of failing node-test-commit-freebsd (✔️)

@danbev

This comment has been minimized.

Copy link
Member

commented May 24, 2019

Landed in 77b9ce5.

@danbev danbev closed this May 24, 2019

danbev added a commit that referenced this pull request May 24, 2019
child_process: remove extra shallow copy
PR-URL: #27801
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request May 28, 2019
child_process: remove extra shallow copy
PR-URL: #27801
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos referenced this pull request Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.