doc: clarify N-API version Matrix. #27942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was asked by a community member if they needed to recompile for v12.x based on the version matrix. Add additional context to help ensure it is clear that this is not the case.
Trott
reviewed
May 28, 2019
Trott
reviewed
May 28, 2019
Trott
reviewed
May 28, 2019
addaleax
added
doc
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
|
@Trott accepted your suggestions |
richardlau
approved these changes
Jun 5, 2019
BethGriggs
approved these changes
Jun 5, 2019
Trott
approved these changes
Jun 5, 2019
boneskull
approved these changes
Jun 5, 2019
There was a problem hiding this comment.
- maybe link to semver.org; people may not know what semver is. or omit the reference entirely and say that NAPI is versioned independently of Node.
- I think the last sentence could be written more clearly. maybe “Projects do not require recompilation when a new version of NAPI is released.”
jasnell
approved these changes
Jun 10, 2019
mhdawson
added
the
author ready
|
Lite CI was good, will land tomorrow. |
|
|
mhdawson
added a commit
that referenced
this pull request
Jun 11, 2019
I was asked by a community member if they needed to recompile for v12.x based on the version matrix. Add additional context to help ensure it is clear that this is not the case. PR-URL: #27942 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Christopher Hiller <boneskull@boneskull.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
I was asked by a community member if they needed to recompile for v12.x based on the version matrix. Add additional context to help ensure it is clear that this is not the case. PR-URL: #27942 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Christopher Hiller <boneskull@boneskull.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was asked by a community member if they needed to
recompile for v12.x based on the version matrix. Add
additional context to help ensure it is clear that this
is not the case.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes