Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x] update openssl to 1.1.1c #28212

Closed

Conversation

@sam-github
Copy link
Member

commented Jun 13, 2019

Backport of #28211, see nodejs/Release#448.

sam-github added some commits Jun 12, 2019

deps: updated openssl upgrade instructions
Patching the s390 asm rules is no longer required.

See: openssl/openssl#8351
deps: upgrade openssl sources to 1.1.1c
This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1c.tar.gz
    $ mv openssl-1.1.1c openssl
    $ git add --all openssl
    $ git commit openssl
deps: update archs files for OpenSSL-1.1.1c
After an OpenSSL source update, all the config files need to be regenerated and
comitted by:
    $ cd deps/openssl/config
    $ make
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/openssl/crypto/include/internal/bn_conf.h
    $ git add deps/openssl/openssl/crypto/include/internal/dso_conf.h
    $ git add deps/openssl/openssl/include/openssl/opensslconf.h
    $ git commit
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Jun 13, 2019

@sam-github sam-github changed the base branch from master to v10.x-staging Jun 13, 2019

@sam-github sam-github referenced this pull request Jun 13, 2019
0 of 4 tasks complete
@nodejs-github-bot

This comment has been minimized.

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

One of the OS X machines failed with a java disconnect, resuming.

@BethGriggs BethGriggs added the v10.x label Jul 25, 2019

BethGriggs added a commit that referenced this pull request Jul 25, 2019

deps: updated openssl upgrade instructions
Patching the s390 asm rules is no longer required.

See: openssl/openssl#8351

PR-URL: #28212
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BethGriggs added a commit that referenced this pull request Jul 25, 2019

deps: upgrade openssl sources to 1.1.1c
This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1c.tar.gz
    $ mv openssl-1.1.1c openssl
    $ git add --all openssl
    $ git commit openssl

PR-URL: #28212
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BethGriggs added a commit that referenced this pull request Jul 25, 2019

deps: update archs files for OpenSSL-1.1.1c
After an OpenSSL source update, all the config files need to be regenerated and
comitted by:
    $ cd deps/openssl/config
    $ make
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/openssl/crypto/include/internal/bn_conf.h
    $ git add deps/openssl/openssl/crypto/include/internal/dso_conf.h
    $ git add deps/openssl/openssl/include/openssl/opensslconf.h
    $ git commit

PR-URL: #28212
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

Landed on v10.x-staging

@BethGriggs BethGriggs closed this Jul 25, 2019

BethGriggs added a commit that referenced this pull request Jul 26, 2019

2019-07-30, Version 10.16.1 'Dubnium' (LTS)
Notable changes:

- **deps**: upgrade openssl sources to 1.1.1c (Sam Roberts) [#28212](#28212)
- **stream**: do not unconditionally call `\_read()` on `resume()` (Anna Henningsen) [#26965](#26965)
- **worker**: fix nullptr deref after MessagePort deser failure (Anna Henningsen) [#25076](#25076)

PR-URL: #28731
@BethGriggs BethGriggs referenced this pull request Jul 26, 2019

BethGriggs added a commit that referenced this pull request Jul 30, 2019

2019-07-30, Version 10.16.1 'Dubnium' (LTS)
Notable changes:

- **deps**: upgrade openssl sources to 1.1.1c (Sam Roberts) [#28212](#28212)
- **stream**: do not unconditionally call `\_read()` on `resume()` (Anna Henningsen) [#26965](#26965)
- **worker**: fix nullptr deref after MessagePort deser failure (Anna Henningsen) [#25076](#25076)

PR-URL: #28731

BethGriggs added a commit that referenced this pull request Jul 31, 2019

2019-07-31, Version 10.16.1 'Dubnium' (LTS)
Notable changes:

- **deps**: upgrade openssl sources to 1.1.1c (Sam Roberts) [#28212](#28212)
- **stream**: do not unconditionally call `\_read()` on `resume()` (Anna Henningsen) [#26965](#26965)
- **worker**: fix nullptr deref after MessagePort deser failure (Anna Henningsen) [#25076](#25076)

PR-URL: #28731

BethGriggs added a commit that referenced this pull request Jul 31, 2019

2019-07-31, Version 10.16.1 'Dubnium' (LTS)
Notable changes:

- **deps**: upgrade openssl sources to 1.1.1c (Sam Roberts) [#28212](#28212)
- **stream**: do not unconditionally call `\_read()` on `resume()` (Anna Henningsen) [#26965](#26965)
- **worker**: fix nullptr deref after MessagePort deser failure (Anna Henningsen) [#25076](#25076)

PR-URL: #28731
@ofrobots

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

FYI, we are seeing some issues with hangs on node startup on systems with when random entropy is low. This seems related to openssl/openssl#8251 openssl/openssl#9078.

@ofrobots

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

(fixed link)

This is with the new 10.16.1 released today.

@sam-github sam-github deleted the sam-github:update-openssl-1.1.1c-v10.x branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.