Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x-backport] src: extract common Bind method #28222

Closed
wants to merge 1 commit into from
Closed

[v10.x-backport] src: extract common Bind method #28222

wants to merge 1 commit into from

Conversation

BethGriggs
Copy link
Member

TCPWrap::Bind and TCPWrap::Bind6 share a large amount of
functionality, so a common Bind was extracted to remove duplication.

PR-URL: #22315

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 14, 2019 •
edited

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23876/
CI: https://ci.nodejs.org/job/node-test-pull-request/23878/

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. net Issues and PRs related to the net subsystem. v10.x labels Jun 14, 2019
@maclover7 @BethGriggs
src: extract common Bind method
f6f25cf 
`TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of
functionality, so a common `Bind` was extracted to remove duplication.

Backport-PR-URL: nodejs#28222
PR-URL: nodejs#22315
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@joyeecheung joyeecheung mentioned this pull request Jun 16, 2019
Closed
@BethGriggs BethGriggs added the review wanted PRs that need reviews. label Jun 28, 2019
mhdawson
mhdawson approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethGriggs BethGriggs removed the review wanted PRs that need reviews. label Jun 28, 2019
BethGriggs pushed a commit that referenced this pull request Jun 28, 2019
@maclover7 @BethGriggs
src: extract common Bind method
07d46a8 
`TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of
functionality, so a common `Bind` was extracted to remove duplication.

Backport-PR-URL: #28222
PR-URL: #22315
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BethGriggs
Copy link
Member Author

Landed on v10.x-staging.

@BethGriggs BethGriggs closed this Jun 28, 2019
BethGriggs pushed a commit that referenced this pull request Jul 17, 2019
@maclover7 @BethGriggs
src: extract common Bind method
0dee607 
`TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of
functionality, so a common `Bind` was extracted to remove duplication.

Backport-PR-URL: #28222
PR-URL: #22315
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BethGriggs @nodejs-github-bot @bnoordhuis @mhdawson @maclover7