Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: make code cache and snapshot deterministic #29142

Closed
wants to merge 3 commits into from
Closed

tools: make code cache and snapshot deterministic #29142

wants to merge 3 commits into from

Commits on Aug 15, 2019

  1. tools: make code cache and snapshot deterministic 

    Use a fixed random seed to ensure that the generated sources are
identical across runs.

The final node binary still reseeds itself on start-up so there should
be no security implications caused by predictable random numbers (e.g.,
`Math.random()`, ASLR, the hash seed, etc.)

Fixes: nodejs#29108
    @bnoordhuis
    bnoordhuis committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    6c2ba8d View commit details
    Browse the repository at this point in the history

  2. fixup! add Math.random() regression test

    @bnoordhuis
    bnoordhuis committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    4d9611c View commit details
    Browse the repository at this point in the history

  3. fixup! fix parallel/test-code-cache test

    @bnoordhuis
    bnoordhuis committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    ed2c673 View commit details
    Browse the repository at this point in the history