Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fixup changelog for v10.16.3 #29159

Closed
wants to merge 1 commit into from
Closed

doc: fixup changelog for v10.16.3 #29159

wants to merge 1 commit into from

Conversation

andrewhughes101
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

cc @BethGriggs

@andrewhughes101
doc: fixup changelog for v10.16.3
30f30e2 
Remove (SEMVER-MINOR) label from patch commit. Add link to table.

Refs: nodejs#26990
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 16, 2019
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 16, 2019
@targos
Copy link
Member

targos commented Aug 16, 2019

👍 to fast-track

@targos
Copy link
Member

targos commented Aug 16, 2019 •
edited
Loading

The link is also missing in https://github.com/nodejs/node/blob/master/CHANGELOG.md

No it's not

@BethGriggs
Copy link
Member

Lite CI: https://ci.nodejs.org/job/node-test-commit-linuxone/15199/ ✅

BethGriggs pushed a commit that referenced this pull request Aug 16, 2019
@andrewhughes101 @BethGriggs
doc: fixup changelog for v10.16.3
791409a 
Remove (SEMVER-MINOR) label from patch commit. Add link to table.

Refs: #26990

PR-URL: #29159
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs
Copy link
Member

Landed in 791409a

Thank you for your contribution 🎉

@BethGriggs BethGriggs closed this Aug 16, 2019
BethGriggs pushed a commit that referenced this pull request Oct 1, 2019
@andrewhughes101 @BethGriggs
doc: fixup changelog for v10.16.3
a3eda28 
Remove (SEMVER-MINOR) label from patch commit. Add link to table.

Refs: #26990

PR-URL: #29159
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Oct 7, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewhughes101 @targos @BethGriggs @addaleax @nodejs-github-bot