Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gyp: rm semicolons (Python != JavaScript) #29228

Closed
wants to merge 1 commit into from
Closed

gyp: rm semicolons (Python != JavaScript) #29228

wants to merge 1 commit into from

Conversation

MattIPv4
Copy link
Member

Checklist

This is a follow-up PR from nodejs/node-gyp#1858 where these changes have been landed upstream (as well as follow-on from #29120).

There are some additional changes not in the upstream PR as it seems the node copy of gyp isn't identical.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Aug 20, 2019
@MattIPv4
Copy link
Member Author

/ping @rvagg @cclauss

@MattIPv4
Copy link
Member Author

I'm going to assume that test failure wasn't my doing?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25127/

@Trott
Copy link
Member

Trott commented Aug 23, 2019

Landed in 6726f56

@Trott Trott closed this Aug 23, 2019
Trott pushed a commit that referenced this pull request Aug 23, 2019
@MattIPv4 @Trott
gyp: remove semicolons (Python != JavaScript)
6726f56 
PR-URL: #29228
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@MattIPv4 MattIPv4 deleted the gyp-semicolons branch August 23, 2019 08:01
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@MattIPv4 @BridgeAR
gyp: remove semicolons (Python != JavaScript)
12cbb3f 
PR-URL: #29228
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
@cclauss cclauss mentioned this pull request Nov 3, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cclauss cclauss cclauss approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@MattIPv4 @nodejs-github-bot @Trott @rvagg @lpinca @cclauss @gengjiawen @richardlau @BridgeAR @trivikr