Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: test Python 3.6 and 3.7 on Travis CI #29291

Closed
wants to merge 1 commit into from

Conversation

@cclauss
Copy link
Contributor

commented Aug 24, 2019

Add a Python 3.6 experimental run to Travis CI because the Python 3.7 run fails early because async is a reserved word in Python >= 3.7.

help wanted:

  1. How can we get the Python 3.6 build to complete before timing out (50 minutes)?
  2. How can we fix the async issue on Python >= 3.7?
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
Trott approved these changes Aug 24, 2019
@cclauss cclauss referenced this pull request Aug 26, 2019
29 of 41 tasks complete
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Trott added a commit that referenced this pull request Aug 27, 2019
build: test Python 3.6 and 3.7 on Travis CI
PR-URL: #29291
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Landed in bfa2683

@Trott Trott closed this Aug 27, 2019

@cclauss cclauss deleted the cclauss:test-Python-3.6-on-Travis-CI branch Aug 27, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
build: test Python 3.6 and 3.7 on Travis CI
PR-URL: #29291
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
BridgeAR added a commit that referenced this pull request Sep 4, 2019
build: test Python 3.6 and 3.7 on Travis CI
PR-URL: #29291
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
build: test Python 3.6 and 3.7 on Travis CI
PR-URL: nodejs#29291
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
build: test Python 3.6 and 3.7 on Travis CI
PR-URL: nodejs#29291
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.