Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove multiple consecutive blank lines #29352

Conversation

@nschonni
Copy link
Contributor

commented Aug 28, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@mhdawson
Copy link
Member

left a comment

LGTM

@nschonni
Copy link
Contributor Author

left a comment

Another one to add back one line

doc/changelogs/CHANGELOG_IOJS.md Show resolved Hide resolved

@nschonni nschonni force-pushed the nschonni:doc--remove-multiple-consecutive-blank-lines branch from 95a14a2 to 4da634e Aug 28, 2019

doc: remove multiple consecutive blank lines
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

@nschonni nschonni force-pushed the nschonni:doc--remove-multiple-consecutive-blank-lines branch from 4da634e to 954d153 Aug 29, 2019

@nschonni

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

Rebased to fix merge conflict

@trivikr

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

Landed in 9a46cfc

@Trott Trott closed this Aug 31, 2019

Trott added a commit that referenced this pull request Aug 31, 2019
doc: remove multiple consecutive blank lines
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: #29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@nschonni nschonni deleted the nschonni:doc--remove-multiple-consecutive-blank-lines branch Aug 31, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
doc: remove multiple consecutive blank lines
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: #29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
BridgeAR added a commit that referenced this pull request Sep 4, 2019
doc: remove multiple consecutive blank lines
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: #29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@XhmikosR

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Does remark-lint have this rule enabled @nschonni?

@nschonni

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

@XhmikosR

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

@nschonni

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

Good idea, I've submitted a PR

JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: remove multiple consecutive blank lines
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: nodejs#29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: remove multiple consecutive blank lines
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: nodejs#29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.