-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: remove the useless parameter for master #29470
Conversation
It seems that at 'RoundRobinHandle', the 'addressType' isn't used but just used at 'SharedHandle', so remove this useless parameter and its related files.
@nodejs/cluster |
From what I understand, this was done this way to give a standard/common interface for handle types, regardless of whether the argument is used by the actual implementation. @cjihrig ... if I'm remembering correctly, you were the one who refactored the implementation and structure of these. Do you have an opinion on this? |
I think it was already like that before I refactored the cluster module a few years back, but I could be remembering incorrectly at this point.
That's my understanding as well. At this point in time I don't think it matters much, but in the future, it's possible that I wouldn't block this from landing, but I'm not enthusiastic enough about it to sign off. |
@MaledongGit this needs a rebase. |
@BridgeAR : done :) |
8ae28ff
to
2935f72
Compare
Unfortunately needs another rebase in order to move forward |
It seems that at 'RoundRobinHandle', the 'addressType' isn't used but just used at 'SharedHandle', so remove this useless parameter and its related files.
make -j4 test
(UNIX), orvcbuild test
(Windows) passes