Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path: replace var with let in lib/path.js #30260

Closed
wants to merge 1 commit into from
Closed

Conversation

@peze
Copy link
Contributor

peze commented Nov 5, 2019

path: replace var with let in lib/path.js

Refs: nodejs/code-and-learn#97

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@peze peze force-pushed the peze:path-var branch from a7ca709 to d10aae6 Nov 5, 2019
@peze peze changed the title test: replace var with let in lib/path.js path: replace var with let in lib/path.js Nov 5, 2019
@trivikr
trivikr approved these changes Nov 5, 2019
lib/path.js Outdated
let start = 0;
let end = -1;
let matchedSlash = true;
let i;

This comment has been minimized.

Copy link
@trivikr

trivikr Nov 5, 2019

Member

nit: this let i can be removef and moved to lines 691 and 731 respectively

Line 691:

for (let i = path.length - 1; i >= start; --i) {

Line 731:

for (let i = path.length - 1; i >= start; --i) {

This comment has been minimized.

Copy link
@peze

peze Nov 6, 2019

Author Contributor

good idea ,i've fixed it;

@peze peze force-pushed the peze:path-var branch from d10aae6 to ff97b76 Nov 6, 2019
@peze peze force-pushed the peze:path-var branch from ff97b76 to 6e728af Nov 6, 2019
@nodejs-github-bot

This comment has been minimized.

@ChALkeR
ChALkeR approved these changes Nov 6, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 9, 2019

Landed in 896b75a

@Trott Trott closed this Nov 9, 2019
Trott added a commit that referenced this pull request Nov 9, 2019
PR-URL: #30260
Refs: nodejs/code-and-learn#97
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 17, 2019
PR-URL: #30260
Refs: nodejs/code-and-learn#97
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30260
Refs: nodejs/code-and-learn#97
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30260
Refs: nodejs/code-and-learn#97
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.