Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: minor updates to releases.md #30636

Closed
wants to merge 1 commit into from

Conversation

@BethGriggs
Copy link
Member

BethGriggs commented Nov 25, 2019

Added note about coordinating major releases with npm

//cc @nodejs/release

Checklist
doc/releases.md Outdated Show resolved Hide resolved
@lpinca
lpinca approved these changes Nov 25, 2019
Copy link
Member

MylesBorins left a comment

LGTM

@targos
targos approved these changes Nov 26, 2019
doc/releases.md Outdated Show resolved Hide resolved
@BethGriggs BethGriggs force-pushed the BethGriggs:release-updates branch from 30c4336 to 6f5f639 Nov 26, 2019
@BethGriggs

This comment has been minimized.

Copy link
Member Author

BethGriggs commented Nov 26, 2019

@yorkie
yorkie approved these changes Nov 26, 2019
BethGriggs added a commit that referenced this pull request Nov 27, 2019
PR-URL: #30636
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
@BethGriggs

This comment has been minimized.

Copy link
Member Author

BethGriggs commented Nov 27, 2019

Landed in 5904dfc

@BethGriggs BethGriggs closed this Nov 27, 2019
@BethGriggs BethGriggs deleted the BethGriggs:release-updates branch Nov 27, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
PR-URL: #30636
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30636
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
bmeck added a commit to bmeck/node that referenced this pull request Dec 2, 2019
PR-URL: nodejs#30636
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30636
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.