src: deprecate native typechecking bindings

doc/api/deprecations.md

@@ -2006,6 +2006,9 @@ could lead to hard to find errors and crashes.
 ### DEP0103: process.binding('util').is\[...\] typechecks
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/30818
+    description: Runtime deprecation.
   - version: v10.9.0
     pr-url: https://github.com/nodejs/node/pull/22004
     description: Superseded by [DEP0111](#DEP0111).
@@ -2014,7 +2017,7 @@ changes:
     description: Documentation-only deprecation.
 -->
 
-Type: Documentation-only (supports [`--pending-deprecation`][])
+Type: Runtime
 
 Using `process.binding()` in general should be avoided. The type checking
 methods in particular can be replaced by using [`util.types`][].

lib/internal/bootstrap/pre_execution.js

@@ -262,13 +262,11 @@ function initializeDeprecations() {
     'isUint8Array',
     'isAnyArrayBuffer'
   ]) {
-    utilBinding[name] = pendingDeprecation ?
-      deprecate(types[name],
-                'Accessing native typechecking bindings of Node ' +
-                'directly is deprecated. ' +
-                `Please use \`util.types.${name}\` instead.`,
-                'DEP0103') :
-      types[name];
+    utilBinding[name] = deprecate(types[name],
+                                  'Accessing native typechecking bindings ' +
+                                  'of Node directly is deprecated. ' +
+                                  `Please use \`util.types.${name}\` instead.`,
+                                  'DEP0103');
   }
 
   // TODO(joyeecheung): this is a legacy property exposed to process.

test/parallel/test-process-isX-deprecation.js

@@ -0,0 +1,33 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+
+[
+  'isArrayBuffer',
+  'isArrayBufferView',
+  'isAsyncFunction',
+  'isDataView',
+  'isDate',
+  'isExternal',
+  'isMap',
+  'isMapIterator',
+  'isNativeError',
+  'isPromise',
+  'isRegExp',
+  'isSet',
+  'isSetIterator',
+  'isTypedArray',
+  'isUint8Array',
+  'isAnyArrayBuffer'
+].forEach((method) => {
+  const { stderr } = spawnSync(process.execPath, ['-p', `
+    process.binding('util')['${method}']('meow');
+  `]);
+  const expectedWarning = '[DEP0103] DeprecationWarning: ' +
+                          'Accessing native typechecking bindings ' +
+                          'of Node directly is deprecated. ' +
+                          `Please use \`util.types.${method}\` instead.`;
+  assert(stderr.includes(expectedWarning), stderr);
+});