Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.13.2 proposal #30865

Closed
wants to merge 226 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
226 commits
Select commit Hold shift + click to select a range
051e27b
tools: check-imports using utf-8
cclauss Nov 2, 2019
a209d41
tools: update certdata.txt
Oct 31, 2019
b1f4507
crypto: update root certificates
Oct 31, 2019
2b162a8
v8: inspect unserializable objects
addaleax Oct 29, 2019
3be9b22
encoding: make TextDecoder handle BOM correctly
addaleax Oct 26, 2019
bca0e0f
src: remove unimplemented method from node.h
addaleax Oct 23, 2019
338d216
src: make AtExit() callbacks run in reverse order
addaleax Nov 2, 2019
5cbe7c2
process: make source map getter resistant against prototype tampering
addaleax Nov 2, 2019
63f937d
doc: update examples in writing-tests.md
GaryGSC Oct 25, 2019
5342f53
v8: mark serdes API as stable
addaleax Nov 3, 2019
ebaa738
tools: make doctool work if no internet available
richardlau Nov 2, 2019
557ad1a
doc: move inactive Collaborators to emeriti
Trott Nov 4, 2019
2bd32a8
http,async_hooks: keep resource object alive from socket
addaleax Oct 31, 2019
5ec3573
src: track no of active JS signal handlers
addaleax Nov 2, 2019
619b718
src: make EndStartedProfilers an exit hook
addaleax Nov 2, 2019
79713ed
src: make WaitForInspectorDisconnect an exit hook
addaleax Nov 2, 2019
b40eede
src: use unique_ptr for InitializeInspector()
addaleax Nov 2, 2019
f97f1ca
src: run RunBeforeExitCallbacks as part of EmitBeforeExit
addaleax Nov 2, 2019
aa30eb5
dgram: reset bind state before emitting error
addaleax Nov 1, 2019
29c8199
dgram: remove listeners on bind error
addaleax Nov 1, 2019
cf89100
doc: update GOVERNANCE.md
Trott Nov 5, 2019
f6498d7
test: deflake test-tls-close-notify.js
lpinca Nov 1, 2019
62e7cf0
tls: refactor tls_wrap.cc
artmaks Nov 6, 2019
ec227c9
module: fix for empty object in InternalModuleReadJSON
guybedford Nov 5, 2019
a3369b2
tls: replace var with let and const
Nov 6, 2019
f0994c6
http: replace vars with lets and consts in lib/_http_agent.js
Nov 6, 2019
7267396
src: persist strings that are used multiple times in the environment
bmsdave Nov 6, 2019
52604fd
https: change var to let in lib/https.js
galinaprokofeva Nov 6, 2019
c01a7fb
fs: change var to let
nadinTs Nov 6, 2019
0e105bd
assert: replace var with let in lib/assert.js
PerfectPan Nov 5, 2019
5c72cc3
cluster: destruct primordials in lib/internal/cluster/worker.js
peze Nov 4, 2019
4ec0b74
buffer: change var to let
darky Nov 6, 2019
0d8c58f
lib: change var to let in lib/_stream_duplex.js
vabole Nov 6, 2019
0828154
dns: switch var to const/let
Nov 6, 2019
75cb026
process: add coverage tests for sourceMapFromDataUrl method
Nov 6, 2019
2f2a8aa
path: replace var with let in lib/path.js
peze Nov 5, 2019
4acd3c3
test: fix test-benchmark-cluster
Trott Nov 9, 2019
fa5c7e5
doc,meta: remove wait period for npm pull requests
Trott Nov 8, 2019
5b2e0f5
deps: update npm to 6.13.0
ruyadorno Nov 5, 2019
879f57d
doc,meta: allow Travis results for doc/comment changes
Trott Nov 8, 2019
4f91459
test: mark test-http-dump-req-when-res-ends as flaky on windows
Nov 6, 2019
deb1824
test: fix Python unittests in ./test and ./tools
cclauss Nov 8, 2019
60a0f1e
doc: add link to node-code-ide-configs in testing
trivikr Nov 1, 2018
b5625f6
stream: increase MAX_HWM
ronag Oct 20, 2019
70cf4d2
http: http_incoming rename var to let and const
Nov 6, 2019
c199570
net: replaced vars to lets and consts
alexahdp Nov 6, 2019
2ece4fe
http: http_common rename var to let and const
Nov 6, 2019
7faa7d1
lib: replaced var to let in lib/v8.js
bmsdave Nov 6, 2019
67e9985
tls: replace var with let
dividead Nov 6, 2019
8274875
doc: fix up N-API doc
mhdawson Nov 4, 2019
d2ab2bb
test: replace Object.assign with object spread
Nov 6, 2019
77abcad
doc, console: remove non-existant methods from docs
SimonSchick Nov 10, 2019
671e028
doc: add lookup to http.request() options
lpinca Nov 10, 2019
be0b53d
crypto: fix key requirements in asymmetric cipher
tniessen Nov 4, 2019
a7d552c
doc: remove "maintenance is supported by" text in BUILDING.md
Trott Nov 12, 2019
5c88500
doc: remove "multiple variants" from BUILDING.md
Trott Nov 12, 2019
04ffa49
doc: simplify text in pull-requests.md
Trott Nov 13, 2019
2b52a3f
test: change var to const in parallel/test-stream-transform-final*
khoumani Nov 12, 2019
1ef1f4f
doc: add entry to url.parse() changes metadata
lpinca Nov 10, 2019
b685d7d
test: deflake test-http-dump-req-when-res-ends.js
lpinca Nov 11, 2019
47fa164
lib: change var to let in string_decoder
Nov 12, 2019
9d6c293
doc: createRequire can take import.meta.url directly
GeoffreyBooth Nov 15, 2019
1413377
url: replace var with let in lib/url.js
xefimx Nov 6, 2019
c722421
doc: update 8.x to 10.x in backporting guide
GaryGSC Nov 14, 2019
56c57d8
lib: replace var with let/const
khoumani Nov 12, 2019
98235d8
util: replace var with let
ssncferreira Nov 12, 2019
7d113af
benchmark: use let instead of var in assert
dnlup Nov 12, 2019
58016e0
tls: change loop var to let
Xavier-Redondo Nov 12, 2019
325dc23
doc: replace const / var with let
duncanhealy Nov 12, 2019
fe8c46a
test: var to const in test-repl-multiline.js
soulmonk Nov 12, 2019
2eec51a
test: changed var to const in test
bassgeta Nov 12, 2019
881de0e
test: change var to let
nath1as Nov 12, 2019
56b3205
src: lib/internal/timers.js var -> let/const
nikolaykrashnikov Nov 6, 2019
1f54cf5
test: improve test-fs-open
artmaks Nov 6, 2019
e8b06e4
build: store cache on timed out builds on Travis
richardlau Nov 13, 2019
833cb00
doc: document timed out Travis CI builds
richardlau Nov 13, 2019
e0982f7
src: enhance feature access `CHECK`s during bootstrap
addaleax Nov 12, 2019
f212dd9
stream: replace var with let
daern91 Nov 12, 2019
6defe54
test: changed var to let in test-repl-editor
jlPhillips-rms Nov 12, 2019
34b136b
test: Change from var to const
Nov 12, 2019
8d9080a
querystring: replace var with let/const
Nov 12, 2019
6908a84
lib: change var to let in internal/streams
marquicodes Nov 12, 2019
2ad7003
benchmark: use let instead of var in async_hooks
dnlup Nov 13, 2019
2960ef1
deps: update nghttp2 to 1.40.0
gengjiawen Nov 15, 2019
8bb232f
doc: adds NO_COLOR to assert doc page
shobhitchittora Nov 14, 2019
376ec01
test: handle undefined default_configuration
codebytere Nov 13, 2019
98963f2
http: revise _http_server.js
Nov 6, 2019
47ee0be
tools: fix build at non-English windows
pd4d10 Nov 15, 2019
a2df87c
lib: change var to let/const in internal/querystring.js
artmaks Nov 6, 2019
6894703
net: destructure primordials
Nov 12, 2019
65af836
src: add file name to 'Module did not self-register' error
nornagon Oct 25, 2019
7aa999b
lib: replace var with let and const in readline.js
VinceOPS Nov 12, 2019
e75498b
lib: replace var with let
Nov 12, 2019
2bcd3a6
test: clean up http-set-trailers
lundibundi Nov 18, 2019
746c67d
deps: upgrade npm to 6.13.1
claudiahdz Nov 18, 2019
a992135
doc: fix overriding of prefix option
lpinca Nov 17, 2019
89f28cc
doc: explain GIT_REMOTE_REF in COLLABORATOR_GUIDE
lundibundi Nov 12, 2019
51a92b9
doc: add mention for using promisify on class methods
lundibundi Nov 10, 2019
a8e40a9
test: add test for options validation of createServer
ZYSzys Nov 19, 2019
984b3c9
http2: remove duplicated assertIsObject
ZYSzys Nov 19, 2019
6e9a1b2
domain: rename var to let and const
marystogova Nov 6, 2019
36b6b05
test: improve assertion message in internet dgram test
Trott Nov 19, 2019
7f3aec7
test: use reserved .invalid TLD for invalid address in test
Trott Nov 19, 2019
aaee981
test: move test not requiring internet from internet to parallel
Trott Nov 19, 2019
18db451
crypto: remove redundant validateUint32 argument
tniessen Nov 21, 2019
4441121
test: refactor test-dgram-multicast-set-interface-lo.js
Nov 18, 2019
bf43bf5
src: fix signal handler crash on close
codebytere Nov 22, 2019
0ce9a9c
test: replace setTimeout with setImmediate in stream test
Trott Nov 20, 2019
dd07ad4
test: use arrow function for callback in stream test
Trott Nov 20, 2019
33de2c6
test: remove string literal as message in strictEqual() in stream test
Trott Nov 20, 2019
b38740d
test: move stream test to parallel
Trott Nov 20, 2019
4dd0f5a
test: move explanatory comment to expected location in file
Trott Nov 20, 2019
c2a5da1
test: add common.mustCall() to stream test
Trott Nov 20, 2019
72aecd7
src,doc: add C++ internals documentation
addaleax Nov 19, 2019
d0d8913
http: destructure primordials in lib/_http_server.js
artmaks Nov 6, 2019
6078d23
repl: change var to let
obelaifa Nov 12, 2019
447c7a1
events: improve performance caused by primordials
antimonyGu Nov 19, 2019
d7d4fe1
fs: cover fs.opendir ERR_INVALID_CALLBACK
darky Nov 6, 2019
b10b72e
readline: change var to let
dnlup Nov 12, 2019
2a44ff5
http2: replace var with let/const
pc3b3r Nov 12, 2019
2f32456
test: switch to object spread in common/benchmark.js
Nov 6, 2019
0654054
lib: replace var to let in cli_table.js
Jing19 Nov 12, 2019
78b2d86
net: replaced vars to lets and consts
nath1as Nov 12, 2019
99770a0
test: test cover cases when trace is empty
Nov 6, 2019
863f772
cluster: replace var by let in shared_handle.js
putxe Nov 12, 2019
69b1e68
test: dns utils replace var
ovhemert Nov 12, 2019
17db4e3
lib: replace var with let/const
Nov 12, 2019
a628fdc
test: change var to let in test-trace-events
jonchurch Nov 12, 2019
0000859
fs: change var to let
alvarp Nov 12, 2019
f1569f3
http2: core.js replace var with let
DanielSchuech Nov 12, 2019
b540ee0
lib: change var to let
dktistakis Nov 12, 2019
1d6ee8b
lib: replace var with let/const
Driesss Nov 12, 2019
b22a946
test: replace var with let in pre_execution.js
Vunovati Nov 12, 2019
6c7e491
test: use spread instead of object.assign
19shubham11 Nov 12, 2019
0b47d82
test: changed var to let in module-errors
jrizza88 Nov 12, 2019
938b894
child_process: replace var with const/let in internal/child_process.js
lcamargof Nov 12, 2019
640cde1
lib: changed var to let
obelaifa Nov 12, 2019
eead424
test: use spread instead of Object.assign
dnlup Nov 12, 2019
c8df932
http: replace var with let
Nov 12, 2019
8a0d1cb
test: change object assign to spread object
putxe Nov 12, 2019
77cbf09
doc: add note about debugging worker_threads
lundibundi Nov 22, 2019
bd78c4f
cluster: replace var with let
Nov 12, 2019
68e8cd3
lib: use let instead of var
edspace Nov 12, 2019
ff9adef
lib: change var to let in stream_base_commons
marquicodes Nov 12, 2019
06251a4
lib: main_thread_only change var to let
matijagaspar Nov 12, 2019
aa65e4b
src: replaced var with let
Nov 12, 2019
2244479
test: code&learn var to let update
Nazaroni Nov 12, 2019
6d63b56
lib: replace var with let
Nov 12, 2019
701a1d5
tools: update ESLint to 6.7.1
cjihrig Nov 22, 2019
d9d6da4
tools: enable more eslint rules
cjihrig Nov 22, 2019
2eaa940
doc: add note of caution about non-conforming streams
ronag Oct 9, 2019
2acf653
doc: document "Resume Build" limitation
richardlau Nov 22, 2019
c50e4f9
test: test for minimum ICU version consistency
richardlau Nov 23, 2019
8a63ea1
test: use useful message argument in test function
Trott Nov 24, 2019
ab25a82
lib: adding perf notes js_stream_socket.js
ryanj Nov 12, 2019
aad324d
test: change object assign by spread operator
putxe Nov 12, 2019
49f3558
http2: change var to let compact.js
MariaEmma Nov 12, 2019
a353179
lib: replace var with let/const
Tijl5 Nov 12, 2019
a7a71d4
child_process: replace var with let/const
dnlup Nov 12, 2019
38d5fea
process: replace vars in per_thread.js
EmaSuriano Nov 12, 2019
ef3ab37
lib: replace var w/ let
IAmEddieDean Nov 12, 2019
a31ace5
cluster: replace vars in child.js
EmaSuriano Nov 12, 2019
2c29db1
process: replace var with let/const
deadbeef84 Nov 12, 2019
a4c404c
util: use let instead of var for util/inspect.js
lmammino Nov 12, 2019
6ff34a5
lib: replace var with let/const
jens-cappelle Nov 12, 2019
363391e
lib: use let instead of var
19shubham11 Nov 12, 2019
5be20b4
doc: add explanation why keep var with for loop
lrecknagel Nov 12, 2019
c5e3816
test: dir class initialisation w/o handler
Nov 6, 2019
5fd943a
test: move test-worker-prof to sequential
Trott Nov 24, 2019
89f6ead
doc: update AUTHORS list
devsnek Nov 26, 2019
ec504e3
doc: add 13 and 12 to previous versions
andrewhughes101 Nov 22, 2019
857669f
doc: minor updates to releases.md
BethGriggs Nov 25, 2019
74e8902
doc: remove "this API is unstable" note for v8 serdes API
bruce-one Nov 24, 2019
dcbe376
tty: truecolor check moved before 256 check
duncanhealy Nov 13, 2019
36f7f88
n-api: add missed nullptr check in napi_has_own_property
lundibundi Nov 24, 2019
cac77dd
test: add regression test for signal handler removal in exit
addaleax Nov 22, 2019
23ad927
test: add mustCall() to test-inspector-contexts
Trott Nov 26, 2019
39c5f94
test: check for session.post() errors in test-insepctor-context
Trott Nov 26, 2019
95dd550
test: remove destructuring from test-inspector-contexts
Trott Nov 26, 2019
d191acc
test: add logging in case of infinite loop
Trott Nov 26, 2019
9de7196
src,doc: fix broken links
cjihrig Nov 26, 2019
43545f3
src: cleanup unused headers
alferpal Nov 7, 2019
61fc754
inspector: properly shut down uv_async_t
addaleax Nov 19, 2019
92c6fa4
tls: allow empty subject even with altNames defined
jasonmacgowan Sep 17, 2018
a596a5d
test: remove unused function argument from http test
Trott Nov 26, 2019
9d4a854
test: do not skip test-http-server-consumed-timeout
Trott Nov 26, 2019
e0bfa43
test: remove unnecessary common.platformTimeout() call
Trott Nov 26, 2019
a2f3f60
test: move test-https-server-consumed-timeout to parallel
Trott Nov 26, 2019
8a92830
deps: update llhttp to 2.0.1
indutny Nov 20, 2019
e2f8d23
http: set socket.server unconditionally
addaleax Nov 20, 2019
a2ef669
child_process: document kill() return value
cjihrig Nov 26, 2019
44b474d
doc: revise socket.connect() note
Trott Nov 27, 2019
5340a2d
doc: address nits for src/README.md
addaleax Nov 28, 2019
5677235
doc: add missing 'added' versions to module.builtinModules
watson Nov 20, 2019
499fb42
n-api: detach external ArrayBuffers on env exit
addaleax Nov 19, 2019
d6c211d
test: port worker + buffer test to N-API
addaleax Nov 19, 2019
053c179
dns: use length for building TXT string
addaleax Nov 27, 2019
f0d4392
buffer: fix 6-byte writeUIntBE() range check
mscdex Nov 13, 2019
c4c5912
test:refactor createHook test
JenyMzo Nov 20, 2019
43f9137
src: remove unused variable in node_dir.cc
gengjiawen Nov 5, 2019
e1b6b33
http2: fix session memory accounting after pausing
Nov 27, 2019
a396a5a
doc: documenting a bit more FreeBSD case
devnexen Nov 8, 2019
fcae355
doc: fixed a typo in process.md
Nov 6, 2019
54cf114
doc: clarify IncomingMessage.destroy() description
XMB5 Nov 4, 2019
27f7f89
tools: add unified plugin changing links for html docs
Oct 12, 2019
1818d9c
doc: note that buf.buffer's contents might differ
strugee Sep 22, 2019
3e58871
benchmark,doc,lib,test: prepare for padding lint rule
Trott Nov 28, 2019
81712c9
tools: enforce blank line between functions
Trott Nov 28, 2019
5ea10a7
test: increase coverage for trace_events.js
Trott Nov 28, 2019
b042e7f
stream: improve performance for sync write finishes
addaleax Nov 29, 2019
804e6e4
test: remove unused callback argument
Trott Nov 29, 2019
ce11088
test: simplify forEach() usage
Trott Nov 29, 2019
e3c9e08
test: remove unused callback argument
Trott Nov 29, 2019
489d333
test: correct header length subtraction
Trott Nov 29, 2019
898f236
doc: update socket.bufferSize text
Trott Nov 30, 2019
0433ed4
doc: update README.md to fix active/maint times
mhdawson Nov 28, 2019
8eecd8a
doc: update signature algorithm in release doc
MylesBorins Nov 26, 2019
d7f1b0c
doc: revise REPL uncaught exception text
Trott Nov 30, 2019
b802d51
test: fix test-benchmark-streams
Trott Dec 2, 2019
ed7dd93
test: use arrow functions in async-hooks tests
GaryGSC Oct 26, 2019
98799d4
doc: fix typographical error
Trott Nov 30, 2019
8dd5eec
build,win: add test-ci-native and test-ci-js
joaocgreis Nov 29, 2019
b18c8d3
build,win: propagate error codes in vcbuild
joaocgreis Nov 30, 2019
8204a74
test: add an indicator `isIBMi`
dmabupt Nov 29, 2019
ac6ff77
test: add coverage for ERR_TLS_INVALID_PROTOCOL_VERSION
Trott Nov 30, 2019
d02ac1c
2019-12-17, Version 12.13.2 'Erbium' (LTS)
BethGriggs Dec 9, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 7 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,14 @@ module.exports = {
'no-class-assign': 'error',
'no-confusing-arrow': 'error',
'no-const-assign': 'error',
'no-constructor-return': 'error',
'no-control-regex': 'error',
'no-debugger': 'error',
'no-delete-var': 'error',
'no-dupe-args': 'error',
'no-dupe-class-members': 'error',
'no-dupe-keys': 'error',
'no-dupe-else-if': 'error',
'no-duplicate-case': 'error',
'no-duplicate-imports': 'error',
'no-empty-character-class': 'error',
Expand Down Expand Up @@ -247,6 +249,7 @@ module.exports = {
'no-return-await': 'error',
'no-self-assign': 'error',
'no-self-compare': 'error',
'no-setter-return': 'error',
'no-shadow-restricted-names': 'error',
'no-tabs': 'error',
'no-template-curly-in-string': 'error',
Expand Down Expand Up @@ -279,6 +282,10 @@ module.exports = {
'one-var': ['error', { initialized: 'never' }],
'one-var-declaration-per-line': 'error',
'operator-linebreak': ['error', 'after'],
'padding-line-between-statements': [
'error',
{ blankLine: 'always', prev: 'function', next: 'function' },
],
'prefer-const': ['error', { ignoreReadBeforeAssign: true }],
'quotes': ['error', 'single', { avoidEscape: true }],
'quote-props': ['error', 'consistent'],
Expand Down
31 changes: 8 additions & 23 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
x-ccache-setup-steps: &ccache-setup-steps
- export CCACHE_NOSTATS=1
- export CCACHE_SLOPPINESS="file_macro,include_file_mtime,include_file_ctime,time_macros,file_stat_matches"
- export CC='ccache gcc-6'
- export CXX='ccache g++-6'

os: linux
language: cpp
# Currently this file can only support one PYTHON_VERSION.
Expand All @@ -16,33 +10,24 @@ env:
jobs:
include:
- stage: "Compile"
name: "Compile V8"
name: "Compile Node.js"
cache: ccache
addons:
apt:
sources:
- ubuntu-toolchain-r-test
packages:
- g++-6
install: *ccache-setup-steps
script:
- pyenv global ${PYTHON_VERSION}
- ./configure
- make -j2 -C out V=1 v8

- name: "Compile Node.js"
cache: ccache
addons:
apt:
sources:
- ubuntu-toolchain-r-test
packages:
- g++-6
install: *ccache-setup-steps
install:
- export CCACHE_NOSTATS=1
- export CCACHE_SLOPPINESS="file_macro,include_file_mtime,include_file_ctime,time_macros,file_stat_matches"
- export CC='ccache gcc-6'
- export CXX='ccache g++-6'
script:
- pyenv global ${PYTHON_VERSION}
- ./configure
- make -j2 V=1
- timeout --preserve-status 45m make -j2 V=1
before_cache:
- cp out/Release/node /home/travis/.ccache
- cp out/Release/cctest /home/travis/.ccache

Expand Down
79 changes: 79 additions & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -2866,5 +2866,84 @@ akitsu-sanae <akitsu.sanae@gmail.com>
Minuk Park <parkm86@gmail.com>
Jim Schlight <jim@inspiredware.com>
Theotime Poisseau <theotime.poisseau@gmail.com>
Alex Zherdev <alex_zherdev@acl.com>
dev-313 <shekhawat.dev313@gmail.com>
Michael Perrotte <mike@npmjs.com>
Alexandre Ferrando <alferpal@gmail.com>
Loris Zinsou <lzinsou@protonmail.com>
Jizu Sun <jizu.sun@sap.com>
AshCripps <Ashley.Cripps@ibm.com>
garygsc <garygsc@gmail.com>
Patrick Housley <patrick.f.housley@gmail.com>
Artem Maksimov <temamaksimov@gmail.com>
Nolik <nolikfriendly@gmail.com>
palmires <palmires@example.com>
Vadim Gorbachev <bmsdave@gmail.com>
galina.prokofeva <g.k.prokofeva@gmail.com>
Nadya <nadin.ts@gmail.com>
PerfectPan <perfectpan325@gmail.com>
peze <cpj1106@gmail.com>
Vladislav Botvin <darkvlados@gmail.com>
Ilia Safronov <ilia.a.safronov@gmail.com>
Dmitriy Kikinskiy <di9@ytka.org>
telenord <nordtelecom.yandex.ru>
alexahdp <alexahdp@gmail.com>
Daniil Pletnev <divided.joy@gmail.com>
Grigoriy Levanov <glevanov@gmail.com>
Simon Schick <demwizzy@gmail.com>
Albert Wang <git@albertyw.com>
Kenza Houmani <khoumani@bloomberg.net>
mkdorff <mkdorff@outlook.com>
xefimx <xefimix@gmail.com>
garygsc <GaryGSC@users.noreply.github.com>
Susana Ferreira <ssncferreira@gmail.com>
Xavier Redondo <xavier.redondo@axa.com>
Duncan Healy <duncan.healy@gmail.com>
SoulMonk <fsoulmonk@gmail.com>
Kerry Mahne <kerry.mahne@gmail.com>
nathias <n@th1.as>
Nikolay Krashnikov <1090219@mail.ru>
daern91 <daniel_eriksson_8@hotmail.com>
JL Phillips <jlphillips@rms.com>
Jure Stepisnik <jure.stepisnik@tretton37.com>
Raoul Jaeckel <raoul.jaeckel@daimler.com>
Kyriakos Markakis <kyriakos@marqui.dev>
Guilherme Goncalves <gsg@ggoncalves.me>
Jesse O'Connor <jessekoconnor@gmail.com>
VinceOPS <vince.g.135@gmail.com>
David OLIVIER <davidolivier1337@gmail.com>
Maria Stogova <masha.stogova@gmail.com>
Taylor Gagne <tgagne@netsurion.com>
Kirlat <kirlat@yula.media>
Lucas Recknagel <lucas91@me.com>
Oliver Belaifa <oliver@belaifa.de>
guzhizhou <guzhizhou28@gmail.com>
Paolo Ceschi Berrini <pc3b3r@gmail.com>
Jing Lin <selinajinglin09@gmail.com>
poutch <damien.pucheu@hotmail.fr>
Tembrechts <Tim.embrechts@emby.ey>
Jon Church <me@jonchurch.com>
Àlvar Pérez <alvarperez92@gmail.com>
Daniel Schuech <dschuech@gmail.com>
Dimitris Ktistakis <dimitris@workable.com>
Dries Stelten <dries.stelten@telenet.be>
Vladimir Adamic <vladimir.adamic@gmail.com>
Shubham Chaturvedi <19shubham11@gmail.com>
Jamar Torres <Jetorres88@gmail.com>
Luis Camargo <luiska1993@gmail.com>
Herrmann, Rene R. (656) <rene.r.herrmann@daimler.com>
Semir Ajruli <ajruli.semir@gmail.com>
matijagaspar <matija.gaspar@gmail.com>
Aldo Ambrosioni <aldo.ambrosioni@accenture.com>
Nazar Malyy <nazar.malyy@gmail.com>
Dennis Saenger <node@mail.ds82.de>
ryan jarvinen <ryan.jarvinen@gmail.com>
Maria Emmanouil <emmanouil.maria@gmail.com>
Tijl Claessens <tijl.claessens@hotmail.com>
EmaSuriano <emanuel.suriano@gmail.com>
Chris Oyler <christopher.oyler@gmail.com>
Jesper Ek <deadbeef84@gmail.com>
Luciano <lucianomammino@gmail.com>
jens-cappelle <jens.jan.cappelle@gmail.com>

# Generated by tools/update-authors.js
28 changes: 17 additions & 11 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,14 @@ There are three support tiers:

* **Tier 1**: These platforms represent the majority of Node.js users. The
Node.js Build Working Group maintains infrastructure for full test coverage.
Maintenance is supported by the Node.js core team. All commits to the
Node.js repository are tested on multiple variants of these platforms. Test
All commits to the Node.js repository are tested on these platforms. Test
failures on tier 1 platforms will block releases.
* **Tier 2**: These platforms represent smaller segments of the Node.js user
base. The Node.js Build Working Group maintains infrastructure for full test
coverage. Maintenance is supported by smaller groups or individuals within
the Node.js core team, or the vendor of the platform itself. All commits to
the Node.js repository are tested on multiple variants of these platforms
where practical. Test failures on tier 2 platforms will block releases.
Delays in release of binaries for these platforms are acceptable
where necessary due to infrastructure concerns.
coverage. All commits to the Node.js repository are tested on these platforms.
Test failures on tier 2 platforms will block releases. Delays in release of
binaries for these platforms are acceptable where necessary due to
infrastructure concerns.
* **Experimental**: May not compile or test suite may not pass. The core team
does not create releases for these platforms. Test failures on experimental
platforms do not block releases. Contributions to improve support for these
Expand Down Expand Up @@ -117,7 +114,7 @@ platforms. This is true regardless of entries in the table below.
| macOS | x64 | >= 10.11 | Tier 1 | |
| SmartOS | x64 | >= 18 | Tier 2 | |
| AIX | ppc64be >=power7 | >= 7.2 TL02 | Tier 2 | |
| FreeBSD | x64 | >= 11 | Experimental | Downgraded as of Node.js 12 |
| FreeBSD | x64 | >= 11 | Experimental | Downgraded as of Node.js 12 <sup>[7](#fn7)</sup> |

<em id="fn1">1</em>: GCC 6 is not provided on the base platform, users will
need the
Expand Down Expand Up @@ -151,6 +148,10 @@ are provided. However, tests in our infrastructure only run on WoW64.
Furthermore, compiling on x86 Windows is currently considered Experimental and
may not be possible.

<em id="fn7">7</em>: The default FreeBSD 12.0 compiler is Clang 6.0.1, but
FreeBSD 12.1 upgrades to 8.0.1. Other Clang/LLVM versions are provided
via the system's package manager, including Clang 9.0.

### Supported toolchains

Depending on the host platform, the selection of toolchains may vary.
Expand Down Expand Up @@ -215,9 +216,10 @@ Supported platforms and toolchains change with each major version of Node.js.
This document is only valid for the current major version of Node.js.
Consult previous versions of this document for older versions of Node.js:

* [Node.js 13](https://github.com/nodejs/node/blob/v13.x/BUILDING.md)
* [Node.js 12](https://github.com/nodejs/node/blob/v12.x/BUILDING.md)
Comment on lines +219 to +220
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically these two are not "older versions of Node.js" but I don't particularly object to the links being here.

* [Node.js 10](https://github.com/nodejs/node/blob/v10.x/BUILDING.md)
* [Node.js 8](https://github.com/nodejs/node/blob/v8.x/BUILDING.md)
* [Node.js 6](https://github.com/nodejs/node/blob/v6.x/BUILDING.md)

## Building Node.js on supported platforms

Expand Down Expand Up @@ -369,6 +371,10 @@ loopback interface on Ubuntu:
sudo sysctl -w net.ipv6.conf.lo.disable_ipv6=0
```

You can use
[node-code-ide-configs](https://github.com/nodejs/node-code-ide-configs)
to run/debug tests, if your IDE configs are present.

#### Running Coverage

It's good practice to ensure any code you add or change is covered by tests.
Expand Down Expand Up @@ -473,7 +479,7 @@ To use the debug build with all the normal dependencies overwrite the release
version in the install directory:

``` console
$ make install --prefix=/opt/node-debug/
$ make install PREFIX=/opt/node-debug/
$ cp -a -f out/Debug/node /opt/node-debug/node
```

Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V12.md#12.13.1">12.13.1</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V12.md#12.13.2">12.13.2</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.13.1">12.13.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.13.0">12.13.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.12.0">12.12.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.11.1">12.11.1</a><br/>
Expand Down
26 changes: 19 additions & 7 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,25 +172,37 @@ the comment anyway to avoid any doubt.
All fixes must have a test case which demonstrates the defect. The test should
fail before the change, and pass after the change.

All pull requests must pass continuous integration tests on the
[project CI server](https://ci.nodejs.org/).
All pull requests must pass continuous integration tests. Code changes must pass
on [project CI server](https://ci.nodejs.org/). Pull requests that only change
documentation and comments can use Travis CI results.

Travis CI jobs have a fixed running time limit that building Node.js sometimes
exceeds. If the `Compile Node.js` Travis CI job has timed out it will fail after
around 45 minutes. The exit code will be 143, indicating that a `SIGTERM` signal
terminated the `make` command. When this happens, restart the timed out job. It
will reuse built artifacts from the previous timed-out run, and thus take less
time to complete.

Do not land any pull requests without passing (green or yellow) CI runs. If
there are CI failures unrelated to the change in the pull request, try "Resume
Build". It is in the left navigation of the relevant `node-test-pull-request`
job. It will preserve all the green results from the current job but re-run
everything else.
everything else. Start a fresh CI if more than seven days have elapsed since
the original failing CI as the compiled binaries for the Windows and ARM
platforms are only kept for seven days.

Some of the CI Jobs may require `GIT_REMOTE_REF` which is the remote portion
of Git refspec. To specify the branch this way `refs/heads/BRANCH` is used
(i.e for `master` -> `refs/heads/master`).
For pull requests it will look like `refs/pull/PR_NUMBER/head`
(i.e. for PR#42 -> `refs/pull/42/head`).

#### Useful CI Jobs

* [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/)
is the CI job to test pull requests. It runs the `build-ci` and `test-ci`
targets on all supported platforms.

* [`node-test-pull-request-lite-pipeline`](https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/)
runs the linter job. It also runs the tests on a very fast host. This is useful
for changes that only affect comments or documentation.

* [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/)
uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run
`npm install && npm test` on a large selection of common modules. This is
Expand Down
3 changes: 3 additions & 0 deletions CPP_STYLE_GUIDE.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# C++ Style Guide

See also the [C++ codebase README](src/README.md) for C++ idioms in the Node.js
codebase not related to stylistic issues.

## Table of Contents

* [Guides and References](#guides-and-references)
Expand Down
36 changes: 16 additions & 20 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,21 @@
## Collaborators

Node.js Core Collaborators maintain the [nodejs/node][] GitHub repository.
The GitHub team for Node.js Core Collaborators is @nodejs/collaborators. Their
privileges include but are not limited to:
The GitHub team for Node.js Core Collaborators is @nodejs/collaborators.
Collaborators have:

* Commit access to the [nodejs/node][] repository
* Access to the Node.js continuous integration (CI) jobs

Both Collaborators and non-Collaborators may propose changes to the Node.js
source code. The mechanism to propose such a change is a GitHub pull request.
Collaborators are responsible for reviewing and merging (_landing_)
pull requests.
Collaborators review and merge (_land_) pull requests.

At least two Collaborators must approve a pull request before the pull request
can land. (One Collaborator approval is enough if the pull request has been open
for more than 7 days.) Approving a pull request indicates that the Collaborator
accepts responsibility for the change. Approval must be from Collaborators who
are not authors of the change.
Two Collaborators must approve a pull request before the pull request can land.
(One Collaborator approval is enough if the pull request has been open for more
than 7 days.) Approving a pull request indicates that the Collaborator accepts
responsibility for the change. Approval must be from Collaborators who are not
authors of the change.

If a Collaborator opposes a proposed change, then the change cannot land. The
exception is if the TSC votes to approve the change despite the opposition.
Expand All @@ -39,13 +38,11 @@ result in Collaborators removing their opposition.

See:

* [Current list of Collaborators](./README.md#current-project-team-members)
* [List of Collaborators](./README.md#current-project-team-members)
* [A guide for Collaborators](./COLLABORATOR_GUIDE.md)

### Collaborator Activities

Typical activities of a Collaborator include:

* Helping users and novice contributors
* Contributing code and documentation changes that improve the project
* Reviewing and commenting on issues and pull requests
Expand All @@ -71,7 +68,7 @@ The current list of TSC members is in
[the project README](./README.md#current-project-team-members).

The [TSC Charter][] governs the operations of the TSC. All changes to the
Charter need approval by the Node.js Board of Directors.
Charter need approval by the OpenJS Foundation Board of Directors.

### TSC Meetings

Expand Down Expand Up @@ -124,7 +121,7 @@ Provide a summary of the nominee's contributions. For example:
* Use the link `https://github.com/nodejs/node/issues?q=commenter:GITHUB_ID`
* Reviews on pull requests in the [nodejs/node][] repository
* Use the link `https://github.com/nodejs/node/pulls?q=reviewed-by:GITHUB_ID`
* Help provided to end users and novice contributors
* Help provided to end-users and novice contributors
* Pull requests and issues opened throughout the Node.js organization
* Use the link `https://github.com/search?q=author:GITHUB_ID+org:nodejs`
* Comments on pull requests and issues throughout the Node.js organization
Expand All @@ -144,16 +141,15 @@ frictionless as possible. Use the [Collaborators discussion page][] to request
feedback from other Collaborators in private. A nominator may also work with the
nominee to improve their contribution profile.

It is possible that Collaborators will overlook someone with valuable
contributions. In that case, the contributor may open an issue or contact a
Collaborator to request a nomination.
Collaborators might overlook someone with valuable contributions. In that case,
the contributor may open an issue or contact a Collaborator to request a
nomination.

### Onboarding

After the nomination passes, a TSC member onboards the new Collaborator. See
[the onboarding guide](./doc/onboarding.md) on details of the onboarding
process. In general, the onboarding should occur within a month after the
nomination passes.
[the onboarding guide](./doc/onboarding.md) for details of the onboarding
process.

## Consensus Seeking Process

Expand Down
Loading