tools: update gyp to 0.5.0 #32698

ryzokuken · 2020-04-07T01:39:09Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

🎉

/cc @targos @cclauss @nodejs/gyp

Thanks for all the lovely work so far, everyone ❤️

aduh95 · 2020-04-07T11:53:22Z

Is there a release note for gyp 0.2.0 available somewhere?

ryzokuken · 2020-04-07T14:32:19Z

@aduh95 we're working on adding a changelog to gyp-extra in nodejs/gyp-next#27. Also, it's hard to add notes for v0.2.0 since it's the first real release of gyp-next and a large percentage of development was done inside this tree, so the history is fragmented. That said, it'll be much better moving forwards, I'd say.

mmarchini · 2020-04-07T17:33:05Z

Nice work! @ryzokuken since a full changelog is probably unfeasible, are there any notable changes you'd like to share?

targos · 2020-04-07T17:46:48Z

The only changes between the current code in node-gyp are related to CI, governance and code style (linter).
This should be functionally equivalent.

gengjiawen · 2020-04-08T11:51:05Z

windows failed with:

[vcvarsall.bat] Environment initialized for: 'x64'
Found MSVS version 16.0
configure  --dest-cpu=x64
Node.js configure: Found Python 3.8.2...
Traceback (most recent call last):
  File "configure", line 24, in <module>
    import configure
  File "D:\a\node\node\configure.py", line 1811, in <module>
    run_gyp(gyp_args)
  File "tools\gyp_node.py", line 54, in run_gyp
    rc = gyp.main(args)
  File "tools\gyp\pylib\gyp\__init__.py", line 679, in main
    return gyp_main(args)
  File "tools\gyp\pylib\gyp\__init__.py", line 664, in gyp_main
    generator.GenerateOutput(flat_list, targets, data, params)
  File "tools\gyp\pylib\gyp\generator\msvs.py", line 2196, in GenerateOutput
    sln = MSVSNew.MSVSSolution(
  File "tools\gyp\pylib\gyp\MSVSNew.py", line 231, in __init__
    self.Write()
  File "tools\gyp\pylib\gyp\MSVSNew.py", line 259, in Write
    f.write(
  File "tools\gyp\pylib\gyp\common.py", line 419, in write
    self.tmp_file.write(s.encode("utf-8"))
TypeError: write() argument must be str, not byte

cclauss · 2020-04-08T13:49:40Z

tools/gyp/pylib/gyp/common.py

-          prefix=os.path.split(filename)[1] + '.gyp.',
-          dir=base_temp_dir)
-      try:
-        self.tmp_file = os.fdopen(tmp_fd, 'wb')


Here we are opening in wb mode...

cclauss · 2020-04-08T13:50:22Z

tools/gyp/pylib/gyp/common.py

+                dir=base_temp_dir,
+            )
+            try:
+                self.tmp_file = os.fdopen(tmp_fd, "w")


... and here we are opening in w mode.

Is it wrong?
It came from this upstream commit that was ported in nodejs/gyp-next#11

I am unsure but it would explain the TypeError: write() argument must be str, not byte above.

@cclauss @targos @gengjiawen could someone point me to the smallest configuration that causes gyp to fail? We could simply add a failing test and patch the relevant line highlighted by @cclauss.

Looks like gyp-next has not been add windows to CI, we can make this as a start ?

@gengjiawen indeed, it has been blocked on the test failures in nodejs/gyp-next#8. I'll try to get it resolved ASAP.

Refs: https://chromium.googlesource.com/external/gyp/+/ab4aca868d68b9de9b20a9991bbbb5e78ab48a30%5E! Refs: nodejs/node#32698 (comment)

Refs: https://chromium.googlesource.com/external/gyp/+/ab4aca868d68b9de9b20a9991bbbb5e78ab48a30 Refs: nodejs/node#32698 (comment)

BridgeAR · 2020-05-25T17:55:31Z

@ryzokuken this needs a rebase and is this otherwise ready to review again?

ryzokuken · 2020-05-25T17:57:07Z

@BridgeAR yeah, I need to make a couple of changes. Sorry for being tardy, I'll find some time to do it later this week. Thanks.

targos · 2020-06-15T06:41:17Z

@ryzokuken would you like to update this to v0.3.0? Otherwise I can do it.

ryzokuken · 2020-06-15T06:42:40Z

@targos sure.

ryzokuken · 2020-07-15T06:51:44Z

@targos PTAL.

targos · 2020-07-15T06:53:14Z

there's a conflict

ryzokuken · 2020-07-15T06:54:52Z

ugh, why did someone push code to a dependency? Let me take a look :/

gengjiawen · 2020-07-15T07:18:15Z

ugh, why did someone push code to a dependency? Let me take a look :/

Most likely #32867.

ryzokuken · 2020-07-15T07:36:02Z

Most likely #32867.

This is definitely it. We need to work harder to make sure all changes to gyp land in the upsteam repo first 😅

@targos do you think moving gyp to deps/gyp would help solve this issue?

ryzokuken · 2020-07-15T07:41:11Z

also, I fixed the merge conflicts locally, but I'm not sure how to proceed with this. Should I upstream these changes to gyp-next, make a new release and update this PR?

gengjiawen · 2020-07-15T09:10:37Z

also, I fixed the merge conflicts locally, but I'm not sure how to proceed with this. Should I upstream these changes to gyp-next, make a new release and update this PR?

+1 on make a new release.

nodejs-github-bot · 2020-10-04T06:14:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33364/

ryzokuken · 2020-10-04T07:49:31Z

CI passed! Landing this.

PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

ryzokuken · 2020-10-04T08:00:45Z

Landed in b79829c...f215a4d 🎉

PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: nodejs#32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

ryzokuken requested review from targos and cclauss April 7, 2020 01:39

ryzokuken self-assigned this Apr 7, 2020

nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Apr 7, 2020

cclauss requested changes Apr 8, 2020

View reviewed changes

ryzokuken mentioned this pull request Apr 14, 2020

GitHub Actions: Enable os: windows-latest nodejs/gyp-next#8

Closed

ryzokuken added a commit to nodejs/gyp-next that referenced this pull request May 3, 2020

fix windows bug

5bc47bb

Refs: https://chromium.googlesource.com/external/gyp/+/ab4aca868d68b9de9b20a9991bbbb5e78ab48a30%5E! Refs: nodejs/node#32698 (comment)

ryzokuken mentioned this pull request May 3, 2020

fix windows bug nodejs/gyp-next#37

Merged

ryzokuken added a commit to nodejs/gyp-next that referenced this pull request May 3, 2020

fix windows bug (#37)

0911664

Refs: https://chromium.googlesource.com/external/gyp/+/ab4aca868d68b9de9b20a9991bbbb5e78ab48a30 Refs: nodejs/node#32698 (comment)

BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18

ryzokuken changed the title ~~tools: update gyp to 0.2.0~~ tools: update gyp to 0.4.0 Jul 15, 2020

gengjiawen requested a review from cclauss July 15, 2020 06:54

tools: update gyp to v0.5.0

b2a6ebd

ryzokuken force-pushed the gyp-0.2.0 branch from dd0084e to b2a6ebd Compare October 4, 2020 06:11

targos approved these changes Oct 4, 2020

View reviewed changes

ryzokuken added a commit that referenced this pull request Oct 4, 2020

tools: update gyp to 0.2.0

a8f5917

PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

ryzokuken added a commit that referenced this pull request Oct 4, 2020

tools: update gyp-next to v0.2.1

535859d

PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

ryzokuken added a commit that referenced this pull request Oct 4, 2020

tools: update gyp-next to v0.3.0

916516c

PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

ryzokuken added a commit that referenced this pull request Oct 4, 2020

tools: update gyp to v0.4.0

e73f0a0

PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

ryzokuken added a commit that referenced this pull request Oct 4, 2020

tools: update gyp to v0.5.0

f215a4d

PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

ryzokuken closed this Oct 4, 2020

danielleadams pushed a commit that referenced this pull request Oct 6, 2020

tools: update gyp to 0.2.0

190d46b

PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

danielleadams pushed a commit that referenced this pull request Oct 6, 2020

tools: update gyp-next to v0.2.1

7361a3f

PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

danielleadams pushed a commit that referenced this pull request Oct 6, 2020

tools: update gyp-next to v0.3.0

3e75907

PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

danielleadams pushed a commit that referenced this pull request Oct 6, 2020

tools: update gyp to v0.4.0

ad8fce6

PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

danielleadams pushed a commit that referenced this pull request Oct 6, 2020

tools: update gyp to v0.5.0

5f1d792

PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

danielleadams mentioned this pull request Oct 6, 2020

V14.13.1 proposal #35525

Merged

This was referenced Nov 2, 2020

How can I improve the build speed of node js? #35888

Open

windows: gyp 0.5.0 made build time multiple times slower #35921

Closed

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021

tools: update gyp to 0.2.0

1867232

PR-URL: nodejs#32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021

tools: update gyp to v0.4.0

75bbf07

PR-URL: nodejs#32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021

tools: update gyp to v0.5.0

92f36f9

PR-URL: nodejs#32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: update gyp to 0.5.0 #32698

tools: update gyp to 0.5.0 #32698

ryzokuken commented Apr 7, 2020

aduh95 commented Apr 7, 2020

ryzokuken commented Apr 7, 2020

mmarchini commented Apr 7, 2020

targos commented Apr 7, 2020

gengjiawen commented Apr 8, 2020

cclauss Apr 8, 2020

cclauss Apr 8, 2020

targos Apr 8, 2020

cclauss Apr 8, 2020

ryzokuken Apr 13, 2020

gengjiawen Apr 14, 2020

ryzokuken Apr 14, 2020

BridgeAR commented May 25, 2020

ryzokuken commented May 25, 2020

targos commented Jun 15, 2020

ryzokuken commented Jun 15, 2020

ryzokuken commented Jul 15, 2020

targos commented Jul 15, 2020

ryzokuken commented Jul 15, 2020

gengjiawen commented Jul 15, 2020

ryzokuken commented Jul 15, 2020

ryzokuken commented Jul 15, 2020

gengjiawen commented Jul 15, 2020

nodejs-github-bot commented Oct 4, 2020

ryzokuken commented Oct 4, 2020

ryzokuken commented Oct 4, 2020 •

edited

tools: update gyp to 0.5.0 #32698

tools: update gyp to 0.5.0 #32698

Conversation

ryzokuken commented Apr 7, 2020

Checklist

aduh95 commented Apr 7, 2020

ryzokuken commented Apr 7, 2020

mmarchini commented Apr 7, 2020

targos commented Apr 7, 2020

gengjiawen commented Apr 8, 2020

cclauss Apr 8, 2020

Choose a reason for hiding this comment

cclauss Apr 8, 2020

Choose a reason for hiding this comment

targos Apr 8, 2020

Choose a reason for hiding this comment

cclauss Apr 8, 2020

Choose a reason for hiding this comment

ryzokuken Apr 13, 2020

Choose a reason for hiding this comment

gengjiawen Apr 14, 2020

Choose a reason for hiding this comment

ryzokuken Apr 14, 2020

Choose a reason for hiding this comment

BridgeAR commented May 25, 2020

ryzokuken commented May 25, 2020

targos commented Jun 15, 2020

ryzokuken commented Jun 15, 2020

ryzokuken commented Jul 15, 2020

targos commented Jul 15, 2020

ryzokuken commented Jul 15, 2020

gengjiawen commented Jul 15, 2020

ryzokuken commented Jul 15, 2020

ryzokuken commented Jul 15, 2020

gengjiawen commented Jul 15, 2020

nodejs-github-bot commented Oct 4, 2020

ryzokuken commented Oct 4, 2020

ryzokuken commented Oct 4, 2020 • edited

ryzokuken commented Oct 4, 2020 •

edited