Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: pipeline don't destroy Duplex src before 'finish' #32966

Closed
wants to merge 2 commits into from
Closed

stream: pipeline don't destroy Duplex src before 'finish' #32966

wants to merge 2 commits into from

Commits on Apr 21, 2020

  1. stream: pipeline don't destroy Duplex src before 'finish' 

    pipeline was too agressive with destroying Duplex
streams which were the first argument into pipeline.

Just because it's !writable does not mean that it
is safe to be destroyed, unless it has also emitted
'finish'.

Fixes: nodejs#32955
    @ronag
    ronag committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    e1edd39 View commit details
    Browse the repository at this point in the history

  2. fixup: nit

    @ronag
    ronag committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    b58909d View commit details
    Browse the repository at this point in the history