Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events:use property, primordials #33775

Closed
wants to merge 2 commits into from
Closed

events:use property, primordials #33775

wants to merge 2 commits into from

Conversation

benjamingr
Copy link
Member

Per Web IDL, EventTarget.prototype[Symbol.toStringTag] should be a data property, not a getter. Commit 56e4460 introduced it as a getter.

This commit uses SymbolToStringTag from primordials and sets it as a property and not a getter.

Thank you Domenic for pointing this out!

Fixes: #33773
cc @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@benjamingr benjamingr requested a review from jasnell June 6, 2020 18:47
@benjamingr benjamingr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 7, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31913/

jasnell pushed a commit that referenced this pull request Jun 18, 2020
@benjamingr @jasnell
events: use property, primordials
ea866dc 
PR-URL: #33775
Fixes: #33773
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 18, 2020

Landed in ea866dc

@jasnell jasnell closed this Jun 18, 2020
codebytere pushed a commit that referenced this pull request Jun 22, 2020
@benjamingr @codebytere
events: use property, primordials
eb01214 
PR-URL: #33775
Fixes: #33773
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@benjamingr @codebytere
events: use property, primordials
17edf65 
PR-URL: #33775
Fixes: #33773
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Sep 22, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lundibundi lundibundi lundibundi approved these changes

@himself65 himself65 himself65 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor EventTarget correctness issues
6 participants
@benjamingr @nodejs-github-bot @jasnell @addaleax @lundibundi @himself65