Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add arrayOfStreams to pipeline #34156

Closed
wants to merge 1 commit into from

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented Jul 1, 2020

Checklist

/cc @ronag

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 1, 2020
@ronag ronag requested review from mcollina and ronag July 1, 2020 13:48
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32186/

@rickyes
Copy link
Contributor Author

rickyes commented Jul 3, 2020

@addaleax
Copy link
Member

addaleax commented Jul 7, 2020

Landed in e0ecde9 🎉

@addaleax addaleax closed this Jul 7, 2020
addaleax pushed a commit that referenced this pull request Jul 7, 2020
PR-URL: #34156
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@rickyes rickyes deleted the test-pipeline-arrayOfstreams branch July 8, 2020 04:17
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
PR-URL: #34156
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
PR-URL: #34156
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere
Copy link
Member

@rickyes does this apply to v12.x? if yes it'd be great if you could open a backport, otherwise please swap the label to dont-land.

rickyes added a commit to rickyes/node that referenced this pull request Sep 28, 2020
PR-URL: nodejs#34156
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@rickyes
Copy link
Contributor Author

rickyes commented Sep 28, 2020

@codebytere backport in #35388

addaleax pushed a commit that referenced this pull request Sep 28, 2020
PR-URL: #34156
Backport-PR-URL: #35388
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants