build: run CI on release branches #34649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
addaleax
approved these changes
Aug 6, 2020
richardlau
reviewed
Aug 6, 2020
codebytere
force-pushed
the
run-push-on-staging
branch
from
9bb5c8d
to
c10555c
Compare
richardlau
approved these changes
Aug 6, 2020
mmarchini
approved these changes
Aug 6, 2020
|
👍🏻 to fast-track? |
codebytere
added a commit
that referenced
this pull request
Aug 6, 2020
PR-URL: #34649 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
|
Landed in e43bb2f |
addaleax
pushed a commit
that referenced
this pull request
Aug 8, 2020
PR-URL: #34649 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Merged
codebytere
added a commit
that referenced
this pull request
Aug 11, 2020
PR-URL: #34649 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also want to run CI on release-related branches, e.g
v14.x-stagingso that Releasers can see if any commits they pushed may have caused issues before opening proposal branches.cc @MylesBorins
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes