test: refactor coverage logic #35767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly.
nodejs-github-bot
added
build
bcoe
commented
Oct 23, 2020
|
|
||
| ```text | ||
| $ make coverage-clean | ||
| $ NODE_V8_COVERAGE=coverage/tmp python tools/test.py test/parallel/test-stream2-transform.js |
There was a problem hiding this comment.
You can just set NODE_V8_COVERAGE, and then run tests any which way.
Makefile
Outdated
| $(RM) out/$(BUILDTYPE)/obj.target/embedtest/src/*.gcno | ||
| $(RM) out/$(BUILDTYPE)/obj.target/embedtest/test/embedding/*.gcno | ||
| $(RM) -r coverage/tmp | ||
| $(FIND) out/$(BUILDTYPE)/obj.target -name "*.gcda" -type f -delete |
There was a problem hiding this comment.
I was having trouble on OSX with left over gcno and gcda files, I believe it's safe to simply remove all files generated by gcov.
| @@ -259,17 +250,10 @@ coverage-test: coverage-build | |||
| @grep -A3 Lines coverage/cxxcoverage.html | grep style \ | |||
| | sed 's/<[^>]*>//g'| sed 's/ //g' | |||
|
|
|||
| COV_REPORT_OPTIONS = --reporter=html \ | |||
| --temp-directory=out/$(BUILDTYPE)/.coverage --omit-relative=false \ | |||
There was a problem hiding this comment.
these options are encapsulated in the .nycrc file.
Codecov Report
@@ Coverage Diff @@
## master #35767 +/- ##
==========================================
- Coverage 96.40% 87.91% -8.50%
==========================================
Files 223 477 +254
Lines 73685 113090 +39405
Branches 0 24628 +24628
==========================================
+ Hits 71038 99419 +28381
- Misses 2647 7956 +5309
- Partials 0 5715 +5715
|
Trott
reviewed
Oct 23, 2020
Trott
reviewed
Oct 23, 2020
Trott
approved these changes
Oct 23, 2020
Co-authored-by: Rich Trott <rtrott@gmail.com>
This comment has been minimized.
This comment has been minimized.
bcoe
added
the
author ready
|
@nodejs/build-files |
Trott
reviewed
Oct 23, 2020
Co-authored-by: Rich Trott <rtrott@gmail.com>
Trott
approved these changes
Oct 23, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
It sure seems as if the Raspberry Pi build failures are related to the Makefile changes here, but I'm not sure how? |
|
In the same vein as "quit and restart the program to see if the problem goes away", I've kicked off a CI with Rebuild rather than Resume Build to see if that fixes it.... |
@Trott odd, I don't think any of the coverage rules should be being executed right? |
|
@Trott restarting worked, but I'm slightly concerned it took so many restarts? |
joyeecheung
approved these changes
Oct 25, 2020
Perhaps the other times were all Resume Builds and not Rebuilds and that is why the results were the same? |
bcoe
added a commit
that referenced
this pull request
Oct 25, 2020
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly. PR-URL: #35767 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in ba907ff |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly. PR-URL: #35767 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly. PR-URL: #35767 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly. PR-URL: #35767 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Mar 3, 2021
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly. PR-URL: #35767 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 6, 2021
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly. PR-URL: #35767 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly.
The coverage logic in the Makefile had become a bit crufty:
nyc, the coverage tool we were using prior toc8.CC: @nodejs/testing
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes