Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: re-word project messaging #36

Closed
wants to merge 1 commit into from
Closed

docs: re-word project messaging #36

wants to merge 1 commit into from

Conversation

kevinohara80
Copy link
Contributor

The previous paragraph was good but a little unclear. This fixes that.

@Fishrock123
Copy link
Member

LGTM, though I think io.js looks nicer as io.js.

@kevinohara80
Copy link
Contributor Author

@Fishrock123 done ^^

@kevinohara80 kevinohara80 mentioned this pull request Dec 3, 2014
Closed
@kevinohara80 kevinohara80 changed the title docs: re-word project messaging #24 docs: re-word project messaging Dec 3, 2014
@rvagg
Copy link
Member

rvagg commented Dec 4, 2014

"io.js" isn't a programatic name so I'm -1 on io.js, I'd hate for that to become the norm for how it's written

@rvagg rvagg force-pushed the v0.12 branch 4 times, most recently from d7e65ff to 185d11c Compare December 4, 2014 10:21
@Fishrock123
Copy link
Member

Yeah Rod is correct, I'm just silly.

@kevinohara80
Copy link
Contributor Author

@rvagg I just removed the back ticks. Agree that formatting should be reserved for programatic items.

@indutny
Copy link
Member

indutny commented Dec 10, 2014

@Fishrock123 @rvagg are we good with this?

@rvagg
Copy link
Member

rvagg commented Dec 10, 2014

sure, the line breaks bother me but that's not a big deal

LGTM

@bnoordhuis
Copy link
Member

I think this needs to be rebased anyway before it can be applied. @kevinohara80 If you could fix the line breaks while you are at it, that would be great.

@kevinohara80
Copy link
Contributor Author

No problem. I'll do this today.

On Wednesday, Dec 10, 2014 at 7:43 AM, Ben Noordhuis notifications@github.com, wrote:

I think this needs to be rebased anyway before it can be applied. @kevinohara80 If you could fix the line breaks while you are at it, that would be great.

—
Reply to this email directly or view it on GitHub.

@kevinohara80
Copy link
Contributor Author

@bnoordhuis @rvagg Rebased and removed whitespace to make it a single paragraph. Let me know if there's any other tweaks.

@bnoordhuis
Copy link
Member

Sorry, I didn't notice it's spread out over multiple commits. Can you squash them and make the commit log conform to what is outlined in CONTRIBUTING.md? git log README.md shows examples. Thanks!

@kevinohara80
docs: reword project messaging
0ac6796 
rewords project messaging in README to make the overall
project messaging a bit clearer. More discussion to be
found in nodejs#24
@kevinohara80
Copy link
Contributor Author

@bnoordhuis My bad. Does this look good?

bnoordhuis pushed a commit that referenced this pull request Dec 10, 2014
@kevinohara80 @bnoordhuis
docs: reword project messaging
6f1d0a8 
Rewords project messaging in README to make the overall project
messaging a bit clearer. More discussion to be found in #24.

PR-URL: #36
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@bnoordhuis
Copy link
Member

Looks great, Kevin. Landed in 6f1d0a8, thanks!

@bnoordhuis bnoordhuis closed this Dec 10, 2014
@jianpingw jianpingw mentioned this pull request Dec 13, 2015
Closed
@lomaster1 lomaster1 mentioned this pull request Feb 19, 2020
Closed
@joyeecheung joyeecheung mentioned this pull request Feb 20, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 26, 2020
Open
@wmertens wmertens mentioned this pull request Jun 19, 2020
Closed
This was referenced Jul 17, 2020
Open
Open
Open
Open
Open
Open
Open
@Flarna Flarna mentioned this pull request Aug 14, 2020
Closed
@silverwind silverwind mentioned this pull request Aug 20, 2020
Closed
@ManuelTS ManuelTS mentioned this pull request Sep 10, 2021
Closed
@ehmicky ehmicky mentioned this pull request Sep 11, 2021
Closed
This was referenced Sep 13, 2021
Open
Open
Open
Open
@solebox solebox mentioned this pull request May 13, 2022
Open
@enterstudio enterstudio mentioned this pull request May 14, 2022
Open
@UbuntuEvangelist UbuntuEvangelist mentioned this pull request May 14, 2022
Open
@s4sc s4sc mentioned this pull request May 14, 2022
Open
@theanarkh theanarkh mentioned this pull request Oct 18, 2022
Closed
@piranna piranna mentioned this pull request Mar 10, 2023
Closed
@lilsweetcaligula lilsweetcaligula mentioned this pull request Mar 16, 2023
Open
@Jamesernator Jamesernator mentioned this pull request Mar 19, 2023
Closed
@aborovsky aborovsky mentioned this pull request Aug 24, 2023
Closed
@B020239 B020239 mentioned this pull request Mar 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kevinohara80 @Fishrock123 @rvagg @indutny @bnoordhuis @piscisaureus @caineio