Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in events.getEventListeners example #36085

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in events.getEventListeners example #36085

wants to merge 1 commit into from

Conversation

Semigradsky
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Nov 11, 2020
benjamingr
benjamingr approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks good catch!

API feedback welcome as well :]

If you want to find more places to contribute - this API could probably use a few more tests as well!

@benjamingr
Copy link
Member

As this is a docs typo and a first time contributor:

👍 to fast track

@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34337/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 11, 2020
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 11, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/36085
✔  Done loading data for nodejs/node/pull/36085
----------------------------------- PR info ------------------------------------
Title      doc: fix typo in `events.getEventListeners` example (#36085)
Author     Dmitry Semigradsky  (@Semigradsky, first-time contributor)
Branch     Semigradsky:patch-1 -> nodejs:master
Labels     author ready, doc, events
Commits    1
 - doc: fix `events.getEventListeners` example
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/36085
Reviewed-By: Luigi Pinca 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36085
Reviewed-By: Luigi Pinca 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Doc-only changes
   ℹ  This PR was created on Wed, 11 Nov 2020 15:54:59 GMT
   ✔  Approvals: 4
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36085#pullrequestreview-528307178
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36085#pullrequestreview-528329331
   ✔  - Yongsheng Zhang (@ZYSzys): https://github.com/nodejs/node/pull/36085#pullrequestreview-528351605
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36085#pullrequestreview-528412376
   ✖  This PR needs to wait 45 more hours to land
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/358244318

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 11, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2020
@github-actions
Copy link
Contributor

Landed in c0ac692...a8b8b8b

@github-actions github-actions bot closed this Nov 11, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 11, 2020
@Semigradsky @nodejs-github-bot
doc: fix events.getEventListeners example
a8b8b8b 
PR-URL: #36085
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@benjamingr
Copy link
Member

Congrats on your first contribution @Semigradsky 🎉 and a personal thanks for fixing my bug!

targos pushed a commit that referenced this pull request May 1, 2021
@Semigradsky @targos
doc: fix events.getEventListeners example
ec140d7 
PR-URL: #36085
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Semigradsky @benjamingr @nodejs-github-bot @lpinca @aduh95 @ZYSzys