Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timers: refactor to use more primordials #36132

Merged
merged 1 commit into from Nov 18, 2020
Merged

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 16, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Trott
Trott approved these changes Nov 16, 2020
lpinca
lpinca approved these changes Nov 16, 2020
@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 17, 2020

PR-URL: nodejs#36132
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott force-pushed the timer-primordials branch from a5e4624 to bd12020 Nov 18, 2020
@Trott Trott merged commit bd12020 into nodejs:master Nov 18, 2020
12 checks passed
@Trott
Copy link
Member

@Trott Trott commented Nov 18, 2020

Landed in bd12020

@aduh95 aduh95 deleted the timer-primordials branch Nov 18, 2020
codebytere added a commit that referenced this issue Nov 22, 2020
PR-URL: #36132
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Nov 22, 2020
targos added a commit that referenced this issue May 16, 2021
PR-URL: #36132
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this issue Jun 11, 2021
PR-URL: #36132
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants