Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: refactor to use more primordials #36140

Closed
wants to merge 1 commit into from

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 16, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Trott
Trott approved these changes Nov 18, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 18, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Nov 19, 2020

Commit Queue failed
- Loading data for nodejs/node/pull/36140
✔  Done loading data for nodejs/node/pull/36140
----------------------------------- PR info ------------------------------------
Title      internal: refactor to use more primordials (#36140)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:main-primordials -> nodejs:master
Labels     author ready
Commits    1
 - internal: refactor to use more primordials
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/36140
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36140
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-11-18T13:54:23Z: https://ci.nodejs.org/job/node-test-pull-request/34452/
- Querying data for job/node-test-pull-request/34452/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Mon, 16 Nov 2020 23:09:37 GMT
   ✔  Approvals: 2
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36140#pullrequestreview-533395778
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36140#pullrequestreview-534528748
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 36140
From https://github.com/nodejs/node
 * branch                  refs/pull/36140/merge -> FETCH_HEAD
✔  Fetched commits as 275aa6845ea7..63bbbf57b02a
--------------------------------------------------------------------------------
[master f60270928c] internal: refactor to use more primordials
 Author: Antoine du Hamel 
 Date: Sun Nov 15 19:18:33 2020 +0100
 2 files changed, 31 insertions(+), 19 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
internal: refactor to use more primordials

PR-URL: #36140
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[master bff8f031f7] internal: refactor to use more primordials
Author: Antoine du Hamel duhamelantoine1995@gmail.com
Date: Sun Nov 15 19:18:33 2020 +0100
2 files changed, 31 insertions(+), 19 deletions(-)
✖ bff8f031f7d02369a8aaadb823bfe98817f5d6c0
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Invalid subsystem: "internal" subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/372812416

aduh95 added a commit that referenced this issue Nov 19, 2020
PR-URL: #36140
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
Copy link
Contributor Author

@aduh95 aduh95 commented Nov 19, 2020

Landed in 3e0194e

@aduh95 aduh95 closed this Nov 19, 2020
@aduh95 aduh95 deleted the main-primordials branch Nov 19, 2020
codebytere added a commit that referenced this issue Nov 22, 2020
PR-URL: #36140
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Nov 22, 2020
targos added a commit that referenced this issue May 16, 2021
PR-URL: #36140
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this issue Jun 11, 2021
PR-URL: #36140
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants