test: increase coverage for fs/dir read #36388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
approved these changes
Dec 4, 2020
Trott
approved these changes
Dec 8, 2020
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Dec 8, 2020
test invalid callback case for fs/dir read Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/internal/fs/dir.js.html#L91
Lxxyx
force-pushed
the
test-fs-dir-coverage
branch
from
055af20
to
23380c0
Compare
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
jasnell
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/36388 ✔ Done loading data for nodejs/node/pull/36388 ----------------------------------- PR info ------------------------------------ Title test: increase coverage for fs/dir read (#36388) Author Lxxyx (@Lxxyx) Branch Lxxyx:test-fs-dir-coverage -> nodejs:master Labels author ready, test Commits 1 - test: increase coverage for fs/dir read Committers 1 - ZiJian Liu PR-URL: https://github.com/nodejs/node/pull/36388 Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/internal/fs/dir.js.html#L91 Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36388 Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/internal/fs/dir.js.html#L91 Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test: increase coverage for fs/dir read ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-12-15T13:28:25Z: https://ci.nodejs.org/job/node-test-pull-request/34951/ - Querying data for job/node-test-pull-request/34951/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Fri, 04 Dec 2020 17:10:35 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36388#pullrequestreview-545159450 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36388#pullrequestreview-547508877 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36388#pullrequestreview-547674870 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/424225407 |
aduh95
approved these changes
Dec 15, 2020
aduh95
added
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 5a637e9...a9c0077 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 15, 2020
test invalid callback case for fs/dir read Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/internal/fs/dir.js.html#L91 PR-URL: #36388 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 21, 2020
test invalid callback case for fs/dir read Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/internal/fs/dir.js.html#L91 PR-URL: #36388 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
test invalid callback case for fs/dir read Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/internal/fs/dir.js.html#L91 PR-URL: #36388 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test invalid callback case for fs/dir read
Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/internal/fs/dir.js.html#L91
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes