Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: refactor to avoid unsafe array iteration #36444

Closed
wants to merge 20 commits into from
Closed

repl: refactor to avoid unsafe array iteration #36444

wants to merge 20 commits into from

Commits on Dec 8, 2020

  1. lib: refactor to remove for-let-of loop in repl.js

    @RaisinTen
    RaisinTen committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    b81f448 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. Apply suggestion from code review 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @RaisinTen @aduh95
    RaisinTen and aduh95 committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    f5d6c33 View commit details
    Browse the repository at this point in the history

  2. lib: require ArrayPrototypeForEach in repl.js

    @RaisinTen
    RaisinTen committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    b6b3c5b View commit details
    Browse the repository at this point in the history

  3. lib: fix syntax error repl.js

    @RaisinTen
    RaisinTen committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    0a167a1 View commit details
    Browse the repository at this point in the history

  4. lib: replace another loop repl.js

    @RaisinTen
    RaisinTen committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    3a9491e View commit details
    Browse the repository at this point in the history

  5. lib: fix lint error repl.js

    @RaisinTen
    RaisinTen committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    846ac65 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @RaisinTen @aduh95
    RaisinTen and aduh95 committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    9367f9b View commit details
    Browse the repository at this point in the history

  2. lib: replace all for loops with ArrayPrototypeForEach in repl.js

    @RaisinTen
    RaisinTen committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    61cb3b7 View commit details
    Browse the repository at this point in the history

  3. lib: fix syntax error repl.js

    @RaisinTen
    RaisinTen committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    10c1759 View commit details
    Browse the repository at this point in the history

  4. lib: fix lint error

    @RaisinTen
    RaisinTen committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    669f93e View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. lib: replace ArrayPrototypeSort with ArrayPrototypeForEach in repl.js

    @RaisinTen
    RaisinTen committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    dc678b0 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. test: add unsafe array iteration test to repl

    @RaisinTen
    RaisinTen committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    ddfbfc4 View commit details
    Browse the repository at this point in the history

  2. test: add notStrictEqual check instead for repl.js

    @RaisinTen
    RaisinTen committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    77a6be5 View commit details
    Browse the repository at this point in the history

  3. Update test/parallel/test-repl-unsafe-array-iteration.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @RaisinTen @aduh95
    RaisinTen and aduh95 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    6c19991 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2020

  1. test: add test using child_process instead

    @RaisinTen
    RaisinTen committed Dec 19, 2020
    1 Configuration menu
    Copy the full SHA
    ccc860a View commit details
    Browse the repository at this point in the history

  2. test: remove error code check

    @RaisinTen
    RaisinTen committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    81776d6 View commit details
    Browse the repository at this point in the history

  3. Update test/parallel/test-repl-unsafe-array-iteration.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @RaisinTen @aduh95
    RaisinTen and aduh95 committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    a45f1ed View commit details
    Browse the repository at this point in the history

  4. Update test/parallel/test-repl-unsafe-array-iteration.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @RaisinTen @aduh95
    RaisinTen and aduh95 committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    c61b0b9 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2020

  1. Update test/parallel/test-repl-unsafe-array-iteration.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @RaisinTen @aduh95
    RaisinTen and aduh95 committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    71350bd View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. Update test/parallel/test-repl-unsafe-array-iteration.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @RaisinTen @aduh95
    RaisinTen and aduh95 committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    1ec7036 View commit details
    Browse the repository at this point in the history