Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix release script #36540

Closed
wants to merge 2 commits into from
Closed

tools: fix release script #36540

wants to merge 2 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 16, 2020 •
edited
Loading

#36123 introduced illformed ssh, scp, and gpg commands. This is my attempt at fixing it.

Refs: #36123 (comment)

/cc @BethGriggs

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 16, 2020
@BethGriggs
Copy link
Member

Thanks for the quick PR, I've just tested this locally, and the script runs through as far as expected:

1) A1AB005C
2) D6DCC25D
Select a key: 1

Using GPG key: A1AB005C
  Fingerprint: 4ED778F539E3634C779C87C6D7062848A1AB005C

# Checking for releases ...
No releases to promote!

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 16, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
aduh95
aduh95 commented Dec 16, 2020
View reviewed changes
tools/release.sh Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34971/

MylesBorins
MylesBorins approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@MylesBorins
Copy link
Contributor

fast-track?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 17, 2020
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2020
Closed
2 tasks
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 17, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 17, 2020
@github-actions
Copy link
Contributor

Landed in 32d58d7...f28715d

@github-actions github-actions bot closed this Dec 17, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 17, 2020
@aduh95 @nodejs-github-bot
tools: fix release script
f28715d 
PR-URL: #36540
Refs: #36123
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@aduh95 aduh95 deleted the fix-release-script branch December 17, 2020 16:43
@BethGriggs
Copy link
Member

I used this version of the script to promote v14.15.3. It successfully promoted the release but I then hit a key related error while uploading the shasums:

Upload files? [y/n] y
Warning: Identity file <key1> not accessible: No such file or directory.
no such identity: <key2>: No such file or directory
dist@direct.nodejs.org's password:

(I reverted to the old version and ran ./tools/release.sh -i <key> -s v14.15.3 to sign.)

@aduh95
Copy link
Contributor Author

aduh95 commented Dec 17, 2020

@BethGriggs Do you try to use the -s flag with the current version by any chance?

@BethGriggs
Copy link
Member

@BethGriggs Do you try to use the -s flag with the current version by any chance?

Nope, I only tried to run the full script with ./tools/release.sh -i <key> on the current version.

@aduh95 aduh95 mentioned this pull request Dec 18, 2020
Closed
2 tasks
targos pushed a commit that referenced this pull request Dec 21, 2020
@aduh95 @targos
tools: fix release script sign function
6c25870 
PR-URL: #36556
Refs: #36540
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request Dec 21, 2020
@aduh95 @targos
tools: fix release script
27260c7 
PR-URL: #36540
Refs: #36123
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit that referenced this pull request Dec 21, 2020
@aduh95 @targos
tools: fix release script sign function
e3c5adc 
PR-URL: #36556
Refs: #36540
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
tools: fix release script
471da7d 
PR-URL: #36540
Refs: #36123
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
tools: fix release script sign function
3cac041 
PR-URL: #36556
Refs: #36540
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
@snyk-bot snyk-bot mentioned this pull request Sep 13, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Sep 13, 2022
Open
This was referenced Sep 13, 2022
Open
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 13, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Sep 14, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aduh95 @BethGriggs @nodejs-github-bot @MylesBorins @Trott @richardlau