v8: fix native serdes constructors

[ExE-Boss]

This removes the indirection added by the class Serializer extends _Serializer {} by utilising THROW_ERR_CONSTRUCT_CALL_REQUIRED from node_errors.h, which is used by MessageChannel to avoid the same issue.

---

This also makes it so that a new Serializer() or new Deserializer(buffer) call with a poisoned Array.prototype[Symbol.iterator] works fine.

---

This also prevents:

Object.getPrototypeOf(require('v8').Serializer)()

from crashing the node process.

Related Issues

Fixes: #13326

Refs: #13541

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[Trott]

This doesn't change the error name (it's still a TypeError) or the error message but does introduce a code where there wasn't one before. This is a good thing and does not seem like a breaking change to me. (It's conceivable that someone is checking for the absence of a code, but...seems unlikely.) I'm inclined to consider the code a new feature and mark this semver-minor. That will get it widely distributed quickly except maybe in maintenance LTS lines, which I think seems about right. Putting my reasoning here in case anyone disagrees and wants to change it. I don't feel strongly about it. I just want to make sure we think about it.

[Trott]

The Fixes points to an issue that's already closed with another fix in place. I guess this replaces the original fix?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/34989/

[addaleax]

I’m still adding the semver-major label because of the read-only prototype change. Sorry, this matches existing behavior. That should be fine then 👍

[github-actions]

Commit Queue failed

- Loading data for nodejs/node/pull/36549
✔  Done loading data for nodejs/node/pull/36549
----------------------------------- PR info ------------------------------------
Title      v8: Fix native `serdes` constructors (#36549)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     ExE-Boss:lib/v8/fix-native-serdes-constructors -> nodejs:master
Labels     C++, author ready, semver-minor, v8 module
Commits    1
 - v8: Fix native `serdes` constructors
Committers 1
 - ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/36549
Fixes: https://github.com/nodejs/node/issues/13326
Refs: https://github.com/nodejs/node/pull/13541
Reviewed-By: Rich Trott 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36549
Fixes: https://github.com/nodejs/node/issues/13326
Refs: https://github.com/nodejs/node/pull/13541
Reviewed-By: Rich Trott 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-12-17T14:15:46Z: https://ci.nodejs.org/job/node-test-pull-request/34989/
- Querying data for job/node-test-pull-request/34989/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Thu, 17 Dec 2020 11:10:14 GMT
   ✔  Approvals: 2
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36549#pullrequestreview-554665625
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36549#pullrequestreview-554904952
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 36549
From https://github.com/nodejs/node
 * branch                  refs/pull/36549/merge -> FETCH_HEAD
✔  Fetched commits as 656ce920a332..3a8ce4d8496c
--------------------------------------------------------------------------------
[master d841a5e21c] v8: Fix native `serdes` constructors
 Author: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
 Date: Thu Dec 17 12:10:00 2020 +0100
 3 files changed, 23 insertions(+), 16 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
   ⚠  Found Fixes: https://github.com/nodejs/node/issues/13326, skipping..
   ⚠  Found Refs: https://github.com/nodejs/node/pull/13541, skipping..
--------------------------------- New Message ----------------------------------
v8: Fix native `serdes` constructors
Fixes: #13326
Refs: #13541
PR-URL: #36549

Reviewed-By: Rich Trott rtrott@gmail.com

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
[master 863ac31b5a] v8: Fix native serdes constructors

Author: ExE Boss 3889017+ExE-Boss@users.noreply.github.com

Date: Thu Dec 17 12:10:00 2020 +0100

3 files changed, 23 insertions(+), 16 deletions(-)

✖  863ac31b5a48f8025406287dad9d7d1d979edcad

✔  1:7      Valid fixes URL.                          fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  5:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✖  0:5      First word after subsystem(s) in title should be lowercase. title-format

✔  0:0      Title is <= 50 columns.                   title-length
ℹ  Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/438086488

[addaleax]

Right, sorry, the commit message :)

Landed in d90fa19