Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: refactor to use more primordials #36651

Closed
wants to merge 2 commits into from

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 27, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Trott
Trott approved these changes Dec 28, 2020
Lxxyx
Lxxyx approved these changes Dec 28, 2020
@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Dec 28, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Dec 31, 2020

Landed in 11b34a9...91e9e01

@github-actions github-actions bot closed this Dec 31, 2020
nodejs-github-bot added a commit that referenced this issue Dec 31, 2020
PR-URL: #36651
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
@aduh95 aduh95 deleted the errors-primordials branch Dec 31, 2020
danielleadams added a commit that referenced this issue Jan 12, 2021
PR-URL: #36651
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
targos added a commit that referenced this issue May 25, 2021
PR-URL: #36651
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
targos added a commit that referenced this issue Jun 5, 2021
PR-URL: #36651
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
targos added a commit that referenced this issue Jun 11, 2021
PR-URL: #36651
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants