Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: change "it's" to "its" where necessary #36913

Closed
wants to merge 1 commit into from
Closed

doc: change "it's" to "its" where necessary #36913

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

No description provided.

@tniessen tniessen added the doc Issues and PRs related to the documentations. label Jan 13, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2021
ItzLevvie
ItzLevvie approved these changes Jan 13, 2021
View reviewed changes
Copy link

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tniessen
Copy link
Member Author

tniessen commented Jan 13, 2021 •
edited
Loading

Collaborators, please add 👍 here to approve fast-tracking this PR.

Edit: Approved by @targos, @cjihrig, @aduh95, and @PoojaDurgad. Fast-tracking.

@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2021
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 13, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jan 13, 2021

I removed the request-ci as this is a doc-only change, and doesn't require a full CI run.

@tniessen
Copy link
Member Author

Green Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4214/

@tniessen @aduh95
doc: change "it's" to "its" where necessary
302060a 
PR-URL: nodejs#36913
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Jan 13, 2021

Landed in 302060a

@aduh95 aduh95 closed this Jan 13, 2021
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
@tniessen tniessen deleted the doc-fix-its-its branch January 15, 2021 17:14
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@tniessen @ruyadorno
doc: change "it's" to "its" where necessary
70cd43c 
PR-URL: #36913
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
@wedataintelligence wedataintelligence mentioned this pull request Jan 12, 2023
Open
This was referenced Jan 12, 2023
Open
Open
@137717unity 137717unity mentioned this pull request Jan 13, 2023
Open
This was referenced Jan 13, 2023
Open
Open
This was referenced Jan 13, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

@aduh95 aduh95 aduh95 approved these changes

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tniessen @aduh95 @lpinca @targos @cjihrig @richardlau @ItzLevvie @PoojaDurgad