Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fixup type in metadata entry #36947

Merged
merged 1 commit into from
Jan 15, 2021
Merged

doc: fixup type in metadata entry #36947

merged 1 commit into from
Jan 15, 2021

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 15, 2021

Minor typo..

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Jan 15, 2021
@jasnell jasnell added fast-track PRs that do not need to wait for 48 hours to land. and removed doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Jan 15, 2021
@jasnell
Copy link
Member Author

jasnell commented Jan 15, 2021

fast-track?

@jasnell jasnell added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Jan 15, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jan 15, 2021

Meta typo in the commit message: type -> typo

@jasnell @aduh95
doc: fixup typo in metadata entry
cd37535 
PR-URL: nodejs#36947
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the fixup-typo-in-workerthreads.md branch from 2f482b6 to cd37535 Compare January 15, 2021 18:26
@aduh95 aduh95 merged commit cd37535 into nodejs:master Jan 15, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jan 15, 2021

Landed in cd37535

ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@jasnell @ruyadorno
doc: fixup typo in metadata entry
aa3bc74 
PR-URL: #36947
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jasnell @aduh95 @gireeshpunathil @targos @nodejs-github-bot