Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: log error in test-fs-realpath-pipe #36996

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Conversation

joyeecheung
Copy link
Member

Show more information when the test fails.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 19, 2021
@joyeecheung joyeecheung added the needs-ci PRs that need a full CI run. label Jan 19, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Show more information when the test fails.

PR-URL: nodejs#36996
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott merged commit 8aea886 into nodejs:master Jan 24, 2021
@Trott
Copy link
Member

Trott commented Jan 24, 2021

Landed in 8aea886

targos pushed a commit that referenced this pull request Feb 2, 2021
Show more information when the test fails.

PR-URL: #36996
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Show more information when the test fails.

PR-URL: #36996
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants