lib: use <array>.push and <array>.unshift instead of <array>.concat #37239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
force-pushed
the
no-array-concat
branch
2 times, most recently
from
a0c23f6
to
a8cf47e
Compare
|
Non-blocking questions: Is performance important for any of the code paths changed here? Are any of these hot paths? If so, can we benchmark? |
jasnell
approved these changes
Feb 23, 2021
|
Needs a rebase. |
marsonya
approved these changes
Feb 24, 2021
aduh95
force-pushed
the
no-array-concat
branch
from
a8cf47e
to
7edadc9
Compare
aduh95
added
the
author ready
aduh95
force-pushed
the
no-array-concat
branch
from
7edadc9
to
d707cda
Compare
Using `push` and `unshift` methods is more performant than reassigning a new array created with `concat`. PR-URL: nodejs#37239 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
force-pushed
the
no-array-concat
branch
from
d707cda
to
83cce87
Compare
|
Landed in 83cce87 |
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
Using `push` and `unshift` methods is more performant than reassigning a new array created with `concat`. PR-URL: #37239 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
pushandunshiftmethods is more performant than reassigning anew array created with
concat.Benchmark for
unshift: https://jsben.ch/KeLG4Benchmark for
push: https://jsben.ch/QtIzg