Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enable no-restricted-syntax rule for test-timers-promisified #37357

Merged
merged 1 commit into from
Feb 15, 2021
Merged

test: enable no-restricted-syntax rule for test-timers-promisified #37357

merged 1 commit into from
Feb 15, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 13, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 13, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36104/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36118/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36127/

Trott added a commit to Trott/io.js that referenced this pull request Feb 15, 2021
@Trott
test: enable no-restricted-syntax rule for test-timers-promisified
f404e70 
PR-URL: nodejs#37357
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@Trott
test: enable no-restricted-syntax rule for test-timers-promisified
b2b887b 
PR-URL: nodejs#37357
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@Trott Trott merged commit b2b887b into nodejs:master Feb 15, 2021
@Trott
Copy link
Member Author

Trott commented Feb 15, 2021

Landed in b2b887b

@Trott Trott deleted the eslintify branch February 15, 2021 22:13
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@Trott @danielleadams
test: enable no-restricted-syntax rule for test-timers-promisified
b09d21b 
PR-URL: #37357
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

@marsonya marsonya marsonya approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Trott @nodejs-github-bot @jasnell @lpinca @aduh95 @marsonya @RaisinTen @targos