lib: simplify check in child_process #37367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
child_process
Lxxyx
approved these changes
Feb 14, 2021
Lxxyx
added
the
author ready
marsonya
approved these changes
Feb 14, 2021
jasnell
approved these changes
Feb 14, 2021
aduh95
approved these changes
Feb 14, 2021
|
CI: https://ci.nodejs.org/job/node-test-pull-request/36129/ (:heavy_check_mark:) |
RaisinTen
added a commit
that referenced
this pull request
Feb 16, 2021
PR-URL: #37367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Landed in 7b17705 |
|
@Lxxyx I'm sorry, I forgot to add your name to the list of reviewers in this commit! Should I amend the commit and force push? |
RaisinTen
added a commit
to RaisinTen/node
that referenced
this pull request
Feb 16, 2021
PR-URL: nodejs#37367 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Landed in 549a11c |
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
PR-URL: #37367 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37367 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.