Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: refactor NativeModule to avoid unsafe array iteration #37656

Merged
merged 1 commit into from Mar 13, 2021

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 8, 2021

No description provided.

Lxxyx
Lxxyx approved these changes Mar 8, 2021
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 8, 2021

PR-URL: nodejs#37656
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@aduh95 aduh95 force-pushed the module-loaders-array-iteration branch from c794620 to 0ccfd7d Mar 13, 2021
@aduh95
Copy link
Contributor Author

@aduh95 aduh95 commented Mar 13, 2021

Landed in 0ccfd7d

@aduh95 aduh95 merged commit 0ccfd7d into nodejs:master Mar 13, 2021
15 of 16 checks passed
@aduh95 aduh95 deleted the module-loaders-array-iteration branch Mar 13, 2021
danielleadams added a commit that referenced this issue Mar 16, 2021
PR-URL: #37656
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
danielleadams added a commit that referenced this issue Mar 16, 2021
PR-URL: #37656
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos added a commit that referenced this issue May 30, 2021
PR-URL: #37656
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos added a commit that referenced this issue Jun 5, 2021
PR-URL: #37656
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos added a commit that referenced this issue Jun 11, 2021
PR-URL: #37656
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants