-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: lint version numbers in doc only in the default branch #37768
Conversation
Changelogs are never backported. I'm okay with this because we usually don't need to validate REPLACEME for other targets than |
Hum that clearly doesn't work as expected, it's skipping this PR even though the PR's targeting |
.github/workflows/linters.yml
Outdated
@@ -51,6 +51,7 @@ jobs: | |||
- name: Environment Information | |||
run: npx envinfo | |||
- name: Get release version numbers | |||
if: ${{ github.event.pull_request.base.ref == github.event.pull_request.base.default_branch }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does GitHub do here then if the condition fails? Does it skip the entire job, or just this step, in which case what is steps.get-released-versions.outputs.NODE_RELEASED_VERSIONS
going to evaluate to in the next step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it skips only this step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It skips the step where it parses the changelogs and validate the version number baed on the pattern only – see https://github.com/nodejs/node/runs/2123211599 for an example.
d57482c
to
bf391df
Compare
fast-track? |
The `lint-md` job on GitHub Actions parses the changelogs to determine if the version numbers referenced in the YAML comments in the docs match actual releases of Node.js. Changelogs are sometimes not backported to release branches; this commit disables changelog parsing on branches other than the default one. Refs: nodejs#37767 PR-URL: nodejs#37768 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com>
bf391df
to
901ef1b
Compare
Landed in 901ef1b |
The `lint-md` job on GitHub Actions parses the changelogs to determine if the version numbers referenced in the YAML comments in the docs match actual releases of Node.js. Changelogs are sometimes not backported to release branches; this commit disables changelog parsing on branches other than the default one. Refs: #37767 PR-URL: #37768 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Changelogs are sometimes not backported to release branches; this check
is useful on the
master
branch, not so much in the other branches.Refs: #37767