Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps,debugger: move node-inspect into core #38161

Merged
merged 12 commits into from
Apr 25, 2021
Merged

deps,debugger: move node-inspect into core #38161

merged 12 commits into from
Apr 25, 2021

Commits on Apr 25, 2021

  1. debugger: move node-inspect to internal library 

    node-inspect developers have agreed to move node-inspect into core
rather than vendor it as a dependency.

Refs: nodejs#36481

PR-URL: nodejs#38161
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    0ca876a View commit details
    Browse the repository at this point in the history

  2. tools: remove node-inspect from license 

    PR-URL: nodejs#38161
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    7ed3969 View commit details
    Browse the repository at this point in the history

  3. debugger: remove unused code 

    Remove code that was for when `node-inspect` was called as a standalone
process.

PR-URL: nodejs#38161
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    21dc0b0 View commit details
    Browse the repository at this point in the history

  4. debugger: fix inspect restart on Windows 

    Fixes: nodejs#37224

PR-URL: nodejs#38161
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    b0713b4 View commit details
    Browse the repository at this point in the history

  5. debugger: accommodate line chunking in Windows 

    PR-URL: nodejs#38161
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    807ede7 View commit details
    Browse the repository at this point in the history

  6. debugger: allow longer time to connect 

    Make five attempts with a timeout of 1 second each rather than 10
attempts with a timeout of 500ms each. This is to allow for
slower-connecting devices like Raspberry Pi.

PR-URL: nodejs#38161
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    c4c9614 View commit details
    Browse the repository at this point in the history

  7. test: fix test-inspector-cli-address 

    The test was assuming that the entire string being sought would arrive
in a single data chunk, but it can be split across multiple chunks.

PR-URL: nodejs#38161
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    c6b4ab0 View commit details
    Browse the repository at this point in the history

  8. test,debugger: migrate node-inspect tests to core 

    Migrate the node-inspect tests to core (where node-inspect code now
lives) and remove node-inspect from deps directory.

PR-URL: nodejs#38161
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    3ef3501 View commit details
    Browse the repository at this point in the history

  9. debugger: replace internal use of deprecated API 

    Change process.binding() use to internalBinding().

PR-URL: nodejs#38161
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    e10525f View commit details
    Browse the repository at this point in the history

  10. test: fix comment typo 

    PR-URL: nodejs#38161
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    0955aae View commit details
    Browse the repository at this point in the history

  11. debugger: fix race condition/deadlock on initialization 

    PR-URL: nodejs#38161
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    60a0764 View commit details
    Browse the repository at this point in the history

  12. test: extend timeout on debugger tests for slower machines 

    PR-URL: nodejs#38161
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    2a70f4f View commit details
    Browse the repository at this point in the history