Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps,debugger: move node-inspect into core #38161

Merged
merged 12 commits into from
Apr 25, 2021
Merged

deps,debugger: move node-inspect into core #38161

merged 12 commits into from
Apr 25, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 9, 2021

Refs: #36481

I named a lot of files/directories with inspector-cli and I suspect inspect-cli or debugger-cli (or just debugger or inspect) would have all been better?

Still some ESLint checks to re-enable in three files, but assuming tests pass everywhere, I think this is good enough to land and things can be adjusted with subsequent PRs.

Because I was porting over the tests, this found and fixed a small bug with node inspect in Node.js 15.x. Specifically, calling scripts would always include internal scripts, even with scripts(false). (Wouldn't mind reconsidering that API as that first argument is a boolean trap. But OMG not when first landing this thing.)

Also there are some changes that landed in the node-inspect repo but never made it into a release. Those changes will need to be ported over. But that's the next PR. (Or maybe the lint fixes would be the next one.)

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Apr 9, 2021
@Trott Trott changed the title Node inspect deps,debugger: move node-inspect into core Apr 9, 2021
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Apr 9, 2021
@Trott Trott requested a review from jkrems April 9, 2021 07:06
@Trott
Copy link
Member Author

Trott commented Apr 9, 2021

@nodejs/diagnostics

@Trott
Copy link
Member Author

Trott commented Apr 9, 2021

(Easier to review, I think, if you look at each commit separately.)

mcollina
mcollina approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jkrems
jkrems approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this!

@Trott Trott force-pushed the node-inspect branch 2 times, most recently from 267e87c to 1069e36 Compare April 10, 2021 05:13
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott
Copy link
Member Author

Trott commented Apr 11, 2021

Anyone know what the right thing to do with this failing test on sharedlibs_openssl300 might be?

https://ci.nodejs.org/job/node-test-commit-linux-containered/26443/nodes=ubuntu1804_sharedlibs_openssl300_x64/testReport/junit/(root)/test/inspector_cli_test_inspector_cli_auto_resume/

/home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/node: error while loading shared libraries: libcrypto.so.3: cannot open shared object file: No such file or directory

@danbev

@Trott
Copy link
Member Author

Trott commented Apr 11, 2021

Getting a lot of ECONNRESET on Windows and wondering how I might make the tests more robust.

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/9309/#showFailuresLink

@nodejs/platform-windows

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@richardlau
Copy link
Member

Anyone know what the right thing to do with this failing test on sharedlibs_openssl300 might be?

https://ci.nodejs.org/job/node-test-commit-linux-containered/26443/nodes=ubuntu1804_sharedlibs_openssl300_x64/testReport/junit/(root)/test/inspector_cli_test_inspector_cli_auto_resume/

/home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/node: error while loading shared libraries: libcrypto.so.3: cannot open shared object file: No such file or directory

@Trott The test needs to pass on the environment when it spawns a child node process — specifically on Linux LD_LIBRARY_PATH needs to be passed on (other operating systems use different but equivalent variables that would need to be passed on if node is dynamically linked to a non-system shared library).

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott
Copy link
Member Author

Trott commented Apr 11, 2021 •
edited

The failed tests in CI on Windows looks (superficially at least) like maybe it's #37224. Might be a significant legitimate bug seen in node-inspect + Node.js 15 + WIndows. Any ideas about how to best fix?

richardlau pushed a commit that referenced this pull request Jul 16, 2021
@Trott @richardlau
test: fix comment typo
24b5e12 
PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@Trott @richardlau
debugger: fix race condition/deadlock on initialization
9c4d8ee 
PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@Trott @richardlau
test: extend timeout on debugger tests for slower machines
562b554 
PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
debugger: move node-inspect to internal library
8bd2a39 
node-inspect developers have agreed to move node-inspect into core
rather than vendor it as a dependency.

Refs: #36481

PR-URL: #38161
Backport-PR-URL: #38858
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
tools: remove node-inspect from license
fc219d8 
PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
debugger: remove unused code
0321c5b 
Remove code that was for when `node-inspect` was called as a standalone
process.

PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
debugger: fix inspect restart on Windows
1da6921 
Fixes: #37224

PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
debugger: accommodate line chunking in Windows
b172e6f 
PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
debugger: allow longer time to connect
22afb7c 
Make five attempts with a timeout of 1 second each rather than 10
attempts with a timeout of 500ms each. This is to allow for
slower-connecting devices like Raspberry Pi.

PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
test: fix test-inspector-cli-address
193ea8f 
The test was assuming that the entire string being sought would arrive
in a single data chunk, but it can be split across multiple chunks.

PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
test,debugger: migrate node-inspect tests to core
a62826b 
Migrate the node-inspect tests to core (where node-inspect code now
lives) and remove node-inspect from deps directory.

PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
debugger: replace internal use of deprecated API
a8924fa 
Change process.binding() use to internalBinding().

PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
test: fix comment typo
dd2642b 
PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
debugger: fix race condition/deadlock on initialization
9e28c6c 
PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
test: extend timeout on debugger tests for slower machines
4d3a1fa 
PR-URL: #38161
Backport-PR-URL: #38858
Refs: #36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: move node-inspect to internal library
f66dc54 
node-inspect developers have agreed to move node-inspect into core
rather than vendor it as a dependency.

Refs: nodejs#36481

PR-URL: nodejs#38161
Backport-PR-URL: nodejs#38858
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
tools: remove node-inspect from license
7bc72ea 
PR-URL: nodejs#38161
Backport-PR-URL: nodejs#38858
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: remove unused code
f9fb7b7 
Remove code that was for when `node-inspect` was called as a standalone
process.

PR-URL: nodejs#38161
Backport-PR-URL: nodejs#38858
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: fix inspect restart on Windows
a3aa347 
Fixes: nodejs#37224

PR-URL: nodejs#38161
Backport-PR-URL: nodejs#38858
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: accommodate line chunking in Windows
3e58e75 
PR-URL: nodejs#38161
Backport-PR-URL: nodejs#38858
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: allow longer time to connect
16f1706 
Make five attempts with a timeout of 1 second each rather than 10
attempts with a timeout of 500ms each. This is to allow for
slower-connecting devices like Raspberry Pi.

PR-URL: nodejs#38161
Backport-PR-URL: nodejs#38858
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
test: fix test-inspector-cli-address
3c5dfc2 
The test was assuming that the entire string being sought would arrive
in a single data chunk, but it can be split across multiple chunks.

PR-URL: nodejs#38161
Backport-PR-URL: nodejs#38858
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
test,debugger: migrate node-inspect tests to core
7bb1e82 
Migrate the node-inspect tests to core (where node-inspect code now
lives) and remove node-inspect from deps directory.

PR-URL: nodejs#38161
Backport-PR-URL: nodejs#38858
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: replace internal use of deprecated API
d535788 
Change process.binding() use to internalBinding().

PR-URL: nodejs#38161
Backport-PR-URL: nodejs#38858
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
test: fix comment typo
80936f8 
PR-URL: nodejs#38161
Backport-PR-URL: nodejs#38858
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: fix race condition/deadlock on initialization
eacadbd 
PR-URL: nodejs#38161
Backport-PR-URL: nodejs#38858
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
test: extend timeout on debugger tests for slower machines
aeca25f 
PR-URL: nodejs#38161
Backport-PR-URL: nodejs#38858
Refs: nodejs#36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Qard Qard Qard approved these changes

@jkrems jkrems jkrems approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Flarna Flarna Flarna approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Trott @nodejs-github-bot @richardlau @targos @jkrems @mcollina @Qard @cjihrig @Flarna