Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 7.25.0 #38378

Closed
wants to merge 2 commits into from
Closed

tools: update ESLint to 7.25.0 #38378

wants to merge 2 commits into from

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 24, 2021

Update ESLint to 7.25.0

Update ESLint to 7.25.0
@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 24, 2021

The update is causing a linter failure on test/parallel/test-tls-transport-destroy-after-own-gc.js 🤔

@targos
Copy link
Member

@targos targos commented Apr 24, 2021

It looks like we need to move the disable comment to where the variable is defined.

aduh95
aduh95 approved these changes Apr 24, 2021
Trott
Trott approved these changes Apr 24, 2021
lpinca
lpinca approved these changes Apr 24, 2021
jasnell added a commit that referenced this issue Apr 26, 2021
Update ESLint to 7.25.0

PR-URL: #38378
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

@jasnell jasnell commented Apr 26, 2021

Landed in 59db84a

@jasnell jasnell closed this Apr 26, 2021
@cjihrig cjihrig deleted the eslint branch Apr 26, 2021
targos added a commit that referenced this issue Apr 29, 2021
Update ESLint to 7.25.0

PR-URL: #38378
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 3, 2021
targos added a commit that referenced this issue May 30, 2021
Update ESLint to 7.25.0

PR-URL: #38378
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this issue Jun 5, 2021
Update ESLint to 7.25.0

PR-URL: #38378
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this issue Jun 5, 2021
Update ESLint to 7.25.0

PR-URL: #38378
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this issue Jun 11, 2021
Update ESLint to 7.25.0

PR-URL: #38378
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants